London | 26 ITP SEP | Russom Gebremeskel | Sprint 2 | Coursework

[russom-g]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Task code

CYF-1039

Changelist

Using documentations errors explained fixed. Program explained step by step.

[abdishakoor-dev]

3-paths.js and 4-random.js are fixed now. Thanks.

Some changes you mention in the threads are not in the PR. For example, 2-time-format.js b) still says "There are no function calls". And 3.js has not changed since 16 September. Maybe the files were not saved, or not pushed. In VS Code, a dot on a file tab means the file is not saved.

Still to do:

1. 1-percentage-change.js a): your lines are right. The question also asks how many calls. Line 4 has two. Write the total.
2. 2-time-format.js b): line 10 has console.log(result). That is a function call. So the answer is 1.
3. 2-mandatory-errors/3.js: go back to your first version on line 2, as in my thread reply. Line 1 stays a number.
4. 2-mandatory-errors/1.js, 2.js and 4.js: add the error type to each. See my comments on those files.
5. 2-time-format.js c) and f): see my comments on lines 33 and 39.
6. Prettier: most of the files you changed still fail the check. Format each one, then push. Format on save stops this coming back: https://github.com/CodeYourFuture/Module-JavaScript-Fundamentals/blob/main/practical_guide.md

Add the Needs Review label again once you have pushed.

[russom-g]

@abdishakoor-dev Everything is updated now.

[abdishakoor-dev]

Marking this Complete. Thank you for sticking with it.

Sorry, my last reply on 3.js was wrong. You had pushed, and I missed it. Your 16th September version worked too, and I should not have asked you to change it.

Please still fix these, as notes for your learning:

1. 2-mandatory-errors/3.js line 2 stops with a TypeError. String and Number have swapped places. Copy this onto line 2:
   const last4Digits = Number(String(cardNumber).slice(-4));
2. Delete Sprint-3/4-mandatory-interpret/.gitignore. It is in the Sprint 3 folder, and this PR is for Sprint 2. Your 3-to-pounds.js is back, so you do not need it.
3. 2-mandatory-errors/1.js has no explanation yet. For example: the original line 3 used const. A const cannot get a new value, so line 4 gave a TypeError. let allows a new value.
4. 3-to-pounds.js lines 14 to 16: you are right that .padEnd(2, "0") never changes anything here. But this exercise asks you to explain the code as it is, and your answer 5 still explains padEnd. Put the original lines back:

   const pence = paddedPenceNumberString
     .substring(paddedPenceNumberString.length - 2)
     .padEnd(2, "0");