Repository navigation
Manchester | 26-ITP-Sept | Monsur Abdulrahman | Sprint 1 | Coursework/form control #1645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Monsur0001
wants to merge
9
commits into
CodeYourFuture:main
Choose a base branch
from
Monsur0001:coursework/form-control
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+162
−8
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1c75dcf
Add initial styles.css file for form controls
Monsur0001 f016fc3
Build T-Shirt form with size options and improve structure
Monsur0001 aab83d0
Update footer to include designer credit
Monsur0001 b9d9c59
Add initial styles for form controls with box-sizing and text alignment
Monsur0001 4973313
Add styles for main section with layout and visual enhancements
Monsur0001 9ed30a0
Enhance form control styles with improved layout and visual consistency
Monsur0001 4339773
Add styles for size options in form controls with flex layout
Monsur0001 5cbfef2
Add styles for radio buttons and enhance submit button appearance
Monsur0001 e537daa
Enhance footer styles for better layout
Monsur0001 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,99 @@ | ||
| <!DOCTYPE html> | ||
| <!doctype html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="utf-8" /> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge" /> | ||
| <title>My form exercise</title> | ||
| <meta name="description" content="" /> | ||
| <meta | ||
| name="form controls" | ||
| content="an exercise on the understanding of form controls" | ||
| /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| <link rel="stylesheet" href="styles.css" /> | ||
| </head> | ||
| <body> | ||
| <header> | ||
| <h1>Product Pick</h1> | ||
| <h1>T-Shirt Product Pick</h1> | ||
| </header> | ||
|
|
||
| <!-- T-Shirt Information Collection Form Design (Name Email and T-shirt color) --> | ||
| <main> | ||
| <form> | ||
| <!-- write your html here--> | ||
| <!-- | ||
| try writing out the requirements first as comments | ||
| this will also help you fill in your PR message later--> | ||
|
|
||
| <div> | ||
| <label for="name">Name</label> | ||
| <input | ||
| type="text" | ||
| name="name" | ||
| id="name" | ||
| minlength="2" | ||
| placeholder="Monsur Abdulrahman" | ||
| required | ||
|
|
||
| /> | ||
| </div> | ||
| <div> | ||
| <label for="email">Email</label> | ||
| <input | ||
| type="email" | ||
| name="email" | ||
| id="email" | ||
| placeholder="monsur@gmail.com" | ||
| required | ||
| /> | ||
| </div> | ||
| <div> | ||
| <label for="color">T-Shirt Color</label> | ||
| <select name="color" id="color" required> | ||
| <option value="">-- Select a color --</option> | ||
| <option value="White">White</option> | ||
| <option value="Green">Green</option> | ||
| <option value="Black">Black</option> | ||
| </select> | ||
| </div> | ||
|
|
||
| <!-- T-shirt Size Column --> | ||
|
|
||
| <fieldset> | ||
| <Legend>Size</Legend> | ||
|
|
||
| <div class="size-option"> | ||
| <input type="radio" name="size" id="xs" required /> | ||
| <label for="xs">XS</label> | ||
|
|
||
| </div> | ||
| <div class="size-option"> | ||
| <input type="radio" name="size" id="s" value="S" /> | ||
| <label for="s">S</label> | ||
|
|
||
| </div> | ||
| <div class="size-option"> | ||
| <input type="radio" name="size" id="m" value="M" /> | ||
| <label for="m">M</label> | ||
|
|
||
| </div> | ||
| <div class="size-option"> | ||
| <input type="radio" name="size" id="l" value="L" /> | ||
| <label for="l">L</label> | ||
| </div> | ||
| <div class="size-option"> | ||
| <input type="radio" name="size" id="xl" value="XL" /> | ||
| <label for="xl">XL</label> | ||
|
|
||
| </div> | ||
| <div class="size-option"> | ||
| <input type="radio" name="size" id="xxl" value="XXL" /> | ||
| <label for="xxl">XXL</label> | ||
|
|
||
| </div> | ||
| </fieldset> | ||
|
|
||
| <button type="submit">Submit</button> | ||
| </form> | ||
| </main> | ||
| <footer> | ||
| <!-- change to your name--> | ||
| <p>By HOMEWORK SOLUTION</p> | ||
| <p>Designed with Love by Monsur Abdulrahman</p> | ||
| </footer> | ||
| </body> | ||
| </html> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| * { | ||
| box-sizing: border-box; | ||
| } | ||
|
|
||
| h1, footer { | ||
| text-align: center; | ||
| } | ||
|
|
||
| main { | ||
| max-width: 400px; | ||
| margin: 50px auto; | ||
| padding: 20px; | ||
| background-color: aliceblue; | ||
| border-radius: 10px; | ||
| box-shadow: 0 4px 6px; | ||
|
|
||
| } | ||
|
|
||
| label { | ||
| display: block; | ||
| margin-bottom: 8px; | ||
| font-weight: bold; | ||
| } | ||
|
|
||
| input, | ||
| select { | ||
| width: 100%; | ||
| padding: 10px; | ||
| margin-bottom: 20px; | ||
| border: 1px solid green; | ||
| border-radius: 5px; | ||
|
|
||
| } | ||
|
|
||
| fieldset { | ||
| display: grid; | ||
| grid-template-columns: 1fr 1fr; | ||
| gap: 10px; | ||
| border: 1px solid green; | ||
| padding: 10px; | ||
| margin-bottom: 5px; | ||
| border-radius: 5px; | ||
|
|
||
|
|
||
|
|
||
| } | ||
|
|
||
| .size-option { | ||
| display: flex; | ||
| align-items: center; | ||
| gap: 5px; | ||
| margin-bottom: 5px; | ||
|
|
||
| } | ||
|
|
||
| input [type="radio"] { | ||
| width: auto; | ||
| margin-bottom: 0; | ||
| } | ||
|
|
||
| button[type="submit"] { | ||
|
|
||
| width: 100%; | ||
| padding: 12px; | ||
| background-color: green; | ||
| color: white; | ||
| border: none; | ||
| border-radius: 5px; | ||
| cursor: pointer; | ||
| font-size: 16px; | ||
|
|
||
| } | ||
|
|
||
| button[type="submit"]:hover { | ||
| background-color: blue; | ||
| } | ||
|
|
||
| footer { | ||
| margin-top: 20px; | ||
| font-size: 0.9em; | ||
|
|
||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although HTML is not case sensitive, I think the original code
<!DOCTYPE html>is correct by convention.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for taking your time to review my code and giving me such detailed feedback, I will work on those suggestions. Thank you so much