Skip to content

Birmingham | 26-ITP-Jan | Mohammed Omer | Sprint 1 | Wireframe#1180

Closed
mo-omer wants to merge 5 commits into
CodeYourFuture:mainfrom
mo-omer:wirefrme
Closed

Birmingham | 26-ITP-Jan | Mohammed Omer | Sprint 1 | Wireframe#1180
mo-omer wants to merge 5 commits into
CodeYourFuture:mainfrom
mo-omer:wirefrme

Conversation

@mo-omer
Copy link
Copy Markdown

@mo-omer mo-omer commented Feb 16, 2026

No description provided.

@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 16, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 213ff2b
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/69976c43b0b0190008f3c845
😎 Deploy Preview https://deploy-preview-1180--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (🟢 up 14 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@mo-omer mo-omer added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 16, 2026
@github-actions
Copy link
Copy Markdown

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 16, 2026
@github-actions
Copy link
Copy Markdown

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented Feb 17, 2026

Please read to Trainee PR Guide to find out how to prepare the PR Description https://programming.codeyourfuture.io/guides/reviewing/trainee-pr-guide/

You were supposed to just modify the files in the Wireframe folder instead of create a new folder. The name feature/wireframe is supposed to be the branch name, not the folder name.

Suggestion: Create a new branch and transfer your code to the new branch, then open a PR from the new branch and close this PR.

Note: Currently your newpage.html looks quite good, but the footer needs to be fixed at the bottom of the viewport to meet one of the requirements.

@mo-omer mo-omer closed this Feb 17, 2026
@mo-omer mo-omer reopened this Feb 19, 2026
@github-actions
Copy link
Copy Markdown

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@mo-omer mo-omer closed this Feb 19, 2026
@mo-omer mo-omer reopened this Feb 20, 2026
@github-actions
Copy link
Copy Markdown

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@mo-omer mo-omer added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 20, 2026
@github-actions
Copy link
Copy Markdown

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Wireframe/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 20, 2026
@github-actions
Copy link
Copy Markdown

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Wireframe/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@mo-omer mo-omer closed this Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants