Birmingham | 26-ITP-Jan | Mohammed Omer | Sprint 2 | Form-Control#1183
Closed
mo-omer wants to merge 2 commits into
Closed
Birmingham | 26-ITP-Jan | Mohammed Omer | Sprint 2 | Form-Control#1183mo-omer wants to merge 2 commits into
mo-omer wants to merge 2 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
mo-omer
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
mo-omer
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
mo-omer
changed the title
mo-omer
added
Needs Review
cjyuan
added
Review in progress
cjyuan
reviewed
Feb 18, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
According to https://validator.w3.org/, there is one warning. Can you address this warning?
|
|
||
| <p> | ||
| <input type="radio" id="red" name="colour" value="red" required /> | ||
| <label for="red">Red</label> |
Contributor
There was a problem hiding this comment.
Could consider wrapping the radio button input inside the label element as
<label>
<input type="radio" name="colour" value="red" required>
Red
</label>
This way, we don't need to use id and for attributes.
Comment on lines
+127
to
+130
| <p> | ||
| <input type="radio" id="blue" name="colour" value="blue" /> | ||
| <label for="blue">Blue</label> | ||
| </p> |
Contributor
There was a problem hiding this comment.
<div> is more appropriate than <p> as a container element here. Can you look into why that is?
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
T-shirt sale form using provided html and css templetes.