London | 26-ITP-May | Jorvan White | Sprint 2 | Wireframe by JorvanW · Pull Request #1320 · CodeYourFuture/Module-Onboarding

JorvanW · 2026-05-20T14:31:07Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

This Pull request is for the wireframe project, ensuring that it meets the requirements.

…Wireframe and Git Branch.

… some changes to the style.css file to make it look better.

netlify · 2026-05-20T14:31:16Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`1f32cd8`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a2065244c1749000815925e
😎 Deploy Preview	https://deploy-preview-1320--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 95 (🟢 up 9 from production) PWA: - View the detailed breakdown and full score reports
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

JorvanW · 2026-05-20T14:35:43Z

When Committing changes from VSCode, the commits would go to my main branch instead of feature/wireframe branch. By the time I realised, for me to change it, the feature/wirerframe branch would show no consistent commits made. In the future I need to make sure the commits aren't being made to the main branch or to just create a new branch in VSCode.

Poonam-raj · 2026-05-22T10:53:56Z

Hi @JorvanW
Your GitHub Bot is still showing issues with the PR template you've submitted on this pull request. Please amend it following the GitHub Bot's suggestions.
Once you've fixed those issues and the bot passes, you will be able to add the "Needs Review" label to submit it for review

Poonam-raj · 2026-05-26T08:58:56Z

Hi Jorvan, I think it might need your "Self checklist" to look like a H2 tag in the markdown. Or perhaps needs a H1 at the top of "Learners, PR Template"

JorvanW · 2026-05-26T09:07:32Z

Hello, I have just added the ## to Self Checklist. Would I need to re-add the needs review tag

Poonam-raj · 2026-05-26T11:20:07Z

Yes Jorvan - re-add it in, if in doubt, if it isn't in the labels section on the right hand side add it in :D

cjyuan

According to https://validator.w3.org/, there are errors in your code. Can you fix them?
I noticed the following issues in the text content:
- Some words are misspelled or use incorrect letter casing.
- Some minor grammar mistakes.
Could you run the content of your HTML document (including HTML code) through an AI tool to identify any potential improvements, even minor ones, to help ensure the content is fully polished?
In terms of the page layout, I'd like you to carefully compare your page against the wireframe and identify any differences in alignment, consistency of element sizing, and whether any elements from the wireframe are missing, omitted, or implemented differently.

For examples,
- Are all the text content properly centered or left-justified?
- Are the articles centered on the page?
- Between the two articles at the bottom of the page, do their image and title fully align horizontally?
- Do all "Read more" links look identical?
Once you've done that review, revisit your implementation and make adjustments where needed to bring the layout closer to the wireframe.

cjyuan · 2026-05-28T16:16:09Z

        <p>
-          Lorem ipsum dolor sit amet consectetur adipisicing elit. Quisquam,
-          voluptates. Quisquam, voluptates.
+          ReadME file is a plain text document that is used as a user manual or official document for a project. This file is useful because it helps communicate important information to those using or collaborating the project. 
        </p>


Note: VS Code formatter could be used to keep our code consistently formatted, including breaking long
lines of HTML text into multiple lines for easier editing and maintenance.

As a best practice, consider following this guide to enable VS Code's
"Format on Save" option or to use its "Format Document" command to ensure your code is always consistently formatted.

Please note that code formatters may not work correctly when the source code contains syntax errors.

cjyuan · 2026-05-28T16:35:48Z

+        <h3>Wireframe</h3>
+        <p>
+         A wireframe is a minimal skeletal blueprint of a website or app interface. It is important in order to plan a project in advance.
+        </p>
+        <a href="https://balsamiq.com/blog/what-are-wireframes/">Read more</a>
+      </article>
+      <article>    
+        <img src="https://miro.medium.com/v2/resize:fit:1100/format:webp/1*nQXC89lqQnqvICtb3J6XWw.png" alt="GitBranch" />
+        <h4>Git Branch </h4>


Why are the articles given different headings?

Could you look up how headings (h1 to h6) should be used in an HTML document?

….html

fixed error in --space: clamp(6px, 6px + 2vw, 15px); Where "2vw" was missing "2" before "vw"

added "margin-top: 55px;" to the "Git-Branch-image" to match the article next to it.

descriptive alt text to the images.

and added a meta description tag for better SEO.

cjyuan

The code is greatly improved. Well done.

I only have a few minor requests.

cjyuan · 2026-06-03T23:00:25Z

-      <p>
-        This is the default, provided code and no changes have been made yet.
-      </p>
+      <p>London | May-2026 | Jorvan White | Wireframe Task </p>


To better match the wireframe, can you keep the footer content centered, and ensure the article content and the footer content won't overlap?

cjyuan · 2026-06-03T23:05:58Z

  --container: 1280px;
 }
+
+H1 {


Normal practice is to consistently use lowercase letters for the element names.

cjyuan · 2026-06-03T23:09:52Z

+#git-branch-image {
+  height: 107%
+}
+
+#git-branch-article h2 {
+    margin-top: 55px;
+}


Indentation is a bit inconsistent.

I strongly recommend enabling
"Format on Save" option in VS Code or to use its "Format Document" command to keep your code consistently formatted.

JorvanW added 4 commits May 20, 2026 14:43

Updated Wireframe/index.html with images and text about README file, …

53be43b

…Wireframe and Git Branch.

Fixed insequential numbering of headings.

8b27fe2

Added links to the read more sections of the index.html file and made…

cbed113

… some changes to the style.css file to make it look better.

added alternative title for images.

60a028e

JorvanW added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 20, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 20, 2026

This comment has been minimized.

Sign in to view

JorvanW added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 23, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 23, 2026

JorvanW added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 26, 2026

JorvanW mentioned this pull request May 26, 2026

26-ITP-May | Onboarding | Jorvan White JorvanW/My-Coursework-Planner#12

Open

LonMcGregor added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels May 27, 2026

cjyuan added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 28, 2026

cjyuan reviewed May 28, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels May 28, 2026

JorvanW added 4 commits May 29, 2026 17:32

Fixed spelling errors in index.html and removed empty <style> tag

4cf50d2

added target="_blank" rel="noopener noreferrer" to all links in index…

f69ac9e

….html

Changes H2 - H4 Tags all to H2 Tags

1406465

Added more semantic HTML tags to the index.html file

095ab92

JorvanW added 8 commits May 31, 2026 17:43

used the container id to wrap and center the page

6f18705

Changed Git-Branch-image for better visibility

4105246

removed div tag in css

e0284e4

fixed error in --space: clamp(6px, 6px + 2vw, 15px); Where "2vw" was missing "2" before "vw"

Change the "Git-branch-image" height to match the aticle next to it.

d31574b

added "margin-top: 55px;" to the "Git-Branch-image" to match the article next to it.

Removed the div tag

e574495

removed id="Article Heading" to <h2>README file</h2>

82964dc

fixed typos in the index.html file and added more

b5f39c7

descriptive alt text to the images.

Added more descriptive links to the index.html file

1f32cd8

and added a meta description tag for better SEO.

JorvanW added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 3, 2026

cjyuan reviewed Jun 3, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 3, 2026

Uh oh!

Conversation

JorvanW commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Self checklist

Changelist

Uh oh!

netlify Bot commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

This comment has been minimized.

This comment has been minimized.

JorvanW commented May 20, 2026

Uh oh!

Poonam-raj commented May 22, 2026

Uh oh!

This comment has been minimized.

Poonam-raj commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JorvanW commented May 26, 2026

Uh oh!

Poonam-raj commented May 26, 2026

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan May 28, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan May 28, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Jun 3, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Jun 3, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Jun 3, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

JorvanW commented May 20, 2026 •

edited

Loading

netlify Bot commented May 20, 2026 •

edited

Loading

Poonam-raj commented May 26, 2026 •

edited

Loading