London | 25-ITP-May | Eyob Zeray | Sprint 1 | Form controls#1383
Open
eyob-tech wants to merge 7 commits into
Open
London | 25-ITP-May | Eyob Zeray | Sprint 1 | Form controls#1383eyob-tech wants to merge 7 commits into
eyob-tech wants to merge 7 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
eyob-tech
added
Needs Review
eyob-tech
added
🏕 Priority Mandatory
Luro91
added
the
Review in progress
Luro91
reviewed
Jun 3, 2026
| <head> | ||
| <meta charset="UTF-8"> | ||
| <title>T-Shirt Order</title> | ||
| <style> |
There was a problem hiding this comment.
How could you separate the code for the styling from the HTML to make it easier to review (because of smaller files with separate responsibilities)
Author
There was a problem hiding this comment.
I moved the CSS from the HTML file into a separate style.css file and linked it to index.html. I tested it with Live Server and the styling is working correctly.
| </main> | ||
| <footer> | ||
| <!-- change to your name--> | ||
| <p>By HOMEWORK SOLUTION</p> |
Author
There was a problem hiding this comment.
I’ve added my name to the exercise and pushed the changes. Thank you for the feedback.
| <h1>Order a T-Shirt</h1> | ||
|
|
||
| <label for="name">Your Name</label> | ||
| <input type="text" id="name" name="name" pattern=".*\S.*\S.*" required> |
There was a problem hiding this comment.
I don't see any errors or warnings in the browser when I input an incorrect values into the fields. How can you ensure this?
Luro91
added
Reviewed
move CSS to separate file
paste CSS here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I created a T-shirt order form by using HTML and CSS only.