Glasgow | May-2026 | Craig Stoddart | Sprint 1 | Form Controls #1413
Open
CraigStodd wants to merge 17 commits into
Open
Glasgow | May-2026 | Craig Stoddart | Sprint 1 | Form Controls #1413CraigStodd wants to merge 17 commits into
CraigStodd wants to merge 17 commits into
Conversation
…dded remaining sizes
- Removed capital letters for id tags in lines 46-47 - Reformatted code with: shift + option + F
-Added value="" to and removed "disabled attribute" from t-shirt colour section
…), ensuring 2 non-space characters requirement
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
CraigStodd
added
the
Needs Review
Author
|
Hi @cjyuan, here is the updated PR with the changes you suggested. |
cjyuan
reviewed
Jun 4, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Changes look good.
I only a few more minor requests.
Comment on lines
+69
to
+72
| <label | ||
| >XS: | ||
| <input type="radio" name="Size" value="XS" required /> | ||
| </label> |
Contributor
There was a problem hiding this comment.
Could you look up "Should the text associated with a radio button be placed on left or right of the radio button?"
Change is optional.
| </div> | ||
| </div> | ||
|
|
||
| <br /> |
Contributor
There was a problem hiding this comment.
Consider using CSS to control spacing between elements instead of using <br> tags. This approach is generally more maintainable and semantically correct.
|
|
||
| <label | ||
| >S: | ||
| <input type="radio" name="Size" value="S" required /> |
Contributor
There was a problem hiding this comment.
The convention is to use lowercase kebab-case values for the name attribute (and also for id and class attributes)
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LINK TO PREVIOUS PR:
Learners, PR Template
Self checklist
Changelist
Updated to include changes suggested in previous pull request.
Implemented changes that meet all requirements for the Form Control exercise