revised function and test for isProperFraction

Author: leerogerfn

implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js

@@ -7,9 +7,17 @@ import test from "node:test";
 
 test("Basic proper fraction", () => {
   // Example: 1/2 is a proper fraction
-  assert.equal(isProperFraction(1, 2), "true");
+  assert.equal(isProperFraction(1, 2), true);
 });
 
 test("Basic proper fraction", () => {
-  assert.equal(isProperFraction(3, 2), "false");
+  assert.equal(isProperFraction(3, 2), false);
+});
+
+test("Basic proper fraction", () => {
+  assert.equal(isProperFraction(0, 2), false);
+});
+
+test("Basic proper fraction", () => {
+  assert.equal(isProperFraction(2, -5), false);
 });

implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -14,8 +14,7 @@
 // execute the code to ensure all tests pass.
 
 export function isProperFraction(numerator, denominator) {
-  if (numerator < denominator) {
-    return "true";
-  }
-  return "false";
+  return numerator > 0 && denominator > 0 && numerator < denominator;
 }
+
+console.log(isProperFraction(2, 6));

implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -4,17 +4,17 @@ import { isProperFraction } from "../implement/2-is-proper-fraction.js";
 
 // Special case: numerator is zero
 test(`should return false when denominator is zero`, () => {
-  expect(isProperFraction(1, 0)).toEqual("false");
+  expect(isProperFraction(1, 0)).toEqual(false);
 });
 
 test(`should return true when denominator is more than numerator`, () => {
-  expect(isProperFraction(1, 4)).toEqual("true");
+  expect(isProperFraction(1, 4)).toEqual(true);
 });
 
 test(`should return false when denominator is less than numerator`, () => {
-  expect(isProperFraction(4, 1)).toEqual("false");
+  expect(isProperFraction(4, 1)).toEqual(false);
 });
 
 test(`should true when denominator and numerator are negative`, () => {
-  expect(isProperFraction(-5, -2)).toEqual("true");
+  expect(isProperFraction(-5, -2)).toEqual(false);
 });