adding negative logic to fraction exercise and tests

Author: AbdennourHachemi

implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js

@@ -40,4 +40,8 @@ test("positive numerator and negative denumerator should return false", () => {
   assert.equal(isProperFraction(5, -16), false);
 });
 
+test("negative numerator smaller then a negative denumerator should return false", () => {
+  assert.equal(isProperFraction(-50 , -16), false);
+});
+
 

implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -14,16 +14,21 @@
 // execute the code to ensure all tests pass.
 
 export function isProperFraction(numerator, denominator) {
- if (Number.isNaN(numerator) || Number.isNaN(denominator)|| denominator===0) {
-   return false;
- }
+  if (
+    Number.isNaN(numerator) ||
+    Number.isNaN(denominator) ||
+    denominator === 0
+  ) {
+    return false;
+  }
   if (!Number.isInteger(numerator) || !Number.isInteger(denominator)) {
     return false;
   }
-  if (numerator >= denominator ) {
+  if (numerator >= denominator) {
     return false;
   }
+  if (numerator < 0 && denominator < 0) {
+    if (Math.abs(numerator) > Math.abs(denominator)) return false;
+  }
   return true;
-
- 
 }