Skip to content

Manchester | 26-ITP-Sep | Mathew Shaibu | Sprint 1 | Structuring and testing data #1635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MattCarolus10 wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Manchester | 26-ITP-Sep | Mathew Shaibu | Sprint 1 | Structuring and testing data #1635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0658917
test for 12:00pm failed
MattCarolus10 Oct 2, 2026
333dbbc
minutes test error 12:30
MattCarolus10 Oct 2, 2026
7a3baaa
1:30pm test error
MattCarolus10 Oct 2, 2026
3e84b2c
00:00 to 12am bug
MattCarolus10 Oct 2, 2026
a87db9c
Fix time formatting in formatAs12HourClock function
MattCarolus10 Oct 2, 2026
3879758
Fix formatting and spacing in formatAs12HourClock function
MattCarolus10 Oct 4, 2026
f8404e8
Refactor time formatting in formatAs12HourClock function and improve …
MattCarolus10 Oct 4, 2026
f9e406f
padStart pm times to stay consistent with am
MattCarolus10 Oct 4, 2026
c375f66
Fix formatting in export statement for consistency
MattCarolus10 Oct 4, 2026
e2ea533
Fix time formatting in test for 24-hour to 12-hour conversion
MattCarolus10 Oct 4, 2026
e0f18e7
Remove console log statement from formatAs12HourClock function
MattCarolus10 Oct 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions format-clock-edge-cases/timeConverter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,19 @@
function formatAs12HourClock(time) {

const hours = Number(time.slice(0, 2));
const minutes = time.slice(3);

@cjyuan cjyuan Oct 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: The .slice() method supports negative indices, which count positions from the end of the string.
For example, str.slice(-3) returns the substring containing last three characters from str.

@MattCarolus10 MattCarolus10 Oct 4, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an error that needs to be fixed, I thought negative values don't make a real time.

@cjyuan cjyuan Oct 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you misunderstood my comment.


if (hours === 12) {
return `12:${minutes}pm`;
}

if (hours === 0) {
return `12:${minutes}am`;
}
Comment thread
cjyuan marked this conversation as resolved.
Resolved

if (hours > 12) {
return `${hours - 12}:00 pm`;
return `${String(hours - 12).padStart(2, "0")}:${minutes}pm`;
}
return `${time} am`;
return `${time}am`;
}

export {formatAs12HourClock};
export { formatAs12HourClock };
26 changes: 21 additions & 5 deletions format-clock-edge-cases/timeConverter.test.js
View file
Open in desktop
Comment thread
cjyuan marked this conversation as resolved.
Resolved
Original file line number Diff line number Diff line change
@@ -1,11 +1,27 @@
import {formatAs12HourClock} from "./timeConverter.js";
import { formatAs12HourClock } from "./timeConverter.js";
import assert from "node:assert";
import test from "node:test";

test("correctly convert time after 12:00", function(){
assert.equal(formatAs12HourClock("23:00"), "11:00 pm");
test("correctly convert time after 12:00", function () {
assert.equal(formatAs12HourClock("23:00"), "11:00pm");
});

test("can correctly convert morning time", function() {
assert.equal(formatAs12HourClock("08:00"), "08:00 am");
test("can correctly convert morning time", function () {
assert.equal(formatAs12HourClock("08:00"), "08:00am");
});

test("can correctly convert morning time", function () {
assert.equal(formatAs12HourClock("12:00"), "12:00pm");
});

test("can correctly convert morning time", function () {
assert.equal(formatAs12HourClock("12:30"), "12:30pm");
});

test("can correctly convert morning time", function () {
assert.equal(formatAs12HourClock("13:30"), "01:30pm");
});

test("can correctly convert morning time", function () {
assert.equal(formatAs12HourClock("00:00"), "12:00am");
});