Repository navigation
Description
Status (2026-10-16)
Fixed in PR #1185 (bugfix/1184 → development). Pirate-bot approved f38d4978, and all checks are green.
- The srcset/sizes enhancement now reads the image tag attribute by attribute, the way a browser does. It only reads and writes the image's own quoted
src/srcset/sizes, at their exact positions;data-*-srcset,data-src,data-sizesand text inside other values are never touched. - An image whose first
srcorsrcsetis adata:placeholder (quoted, unquoted, spaced or uppercase) is left to its lazy loader, including itssizes. This covers the QA agent's finding. - Verified on
testing.optimole.com/envira-test-page/: gallery 92 image 4 keeps Envira's placeholdersrcset, with no duplicatesizes. The Firefox Envira E2E test passes on the PR. - A differential run against
development(124 cases through the full replacer) changed no CDN URL replacement. Onlysrcset/sizesdiffer, in 2 cases. - Not enhanced any more (they keep their CDN
src): malformed markup such asalt=can't, and partly JSON-escaped markup (src="https:\/\/…"). - Not changed: when an image's own
srcsetusesxdescriptors, addingwentries still mixes them; repeatedsizesbreakpoints remain the Profiled width candidates can deliver twice their advertised intrinsic width with Retina Quality #1111 / Generated sizes attribute can contain duplicate max-width conditions #1113 area. - The second QA run found that an image with a
data:placeholder indata-srcbefore its realsrcgets no profiler srcset, ondevelopmenttoo. The image parser takes the placeholder as the image URL; filed separately as Image parser uses a data: placeholder from data-src as the image URL, so the real src misses srcset enhancement #1186. development(and the release PR Release #1169) keep failing this E2E test until fix: keep missing-srcset enhancement off data-* and lazy-load placeholder attributes #1185 is merged.
Summary
When the page profiler has missing-srcset data for an image, Optml_Tag_Replacer::add_missing_srcset_attributes() rewrites the wrong attributes. Its srcset= / sizes= / src= regexes are not anchored to an attribute name, so they also match data-*-srcset, data-*-sizes and data-*-src attributes that lazy-load and gallery plugins use.
On Envira Gallery images this:
- reads the existing value from
data-envira-srcset(the first match) instead ofsrcset; - writes the merged value into every match, so Envira's placeholder
srcset="data:image/gif;base64,…"is replaced with real CDN candidates; - inserts
sizesafter both the real and thedata-envira-srcsetattribute, so the tag ends up with twosizesattributes; - mixes
xandwdescriptors in onesrcset(… 2x, … 254w, … 400w), which is invalid.
Because the placeholder srcset is gone, the browser downloads the image immediately instead of leaving it to Envira's lazy loader. In Firefox that load finishes before Envira's justifiedGallery init, and the init then resets src to data-safe-src (the GIF placeholder). The image still shows (from srcset), but the markup no longer matches what the gallery script expects, and lazy loading is defeated for that image.
Steps to reproduce
- Envira Gallery Lite gallery on a page, Optimole connected, lazy load in viewport mode.
- Visit the page so
optimizer.jsstores a missing-srcset measurement for one gallery image (the profile inOptml_Manager::instance()->page_profiler). - Reload and look at that image's tag.
Live example: http://testing.optimole.com/envira-test-page/, gallery 92, attachment 18 (#envira-gallery-wrap-92 #envira-gallery-image-18).
Expected: srcset keeps Envira's data: placeholder, data-envira-srcset is not touched, one sizes attribute.
Actual:
<img … class="envira-gallery-image envira-gallery-image-4 envira-normal envira-lazy"
src="https://….i.optimole.com/…/w:254/h:300/…/marina-mazur-…-scaled.jpg"
data-envira-srcset="… 2x, … 254w, … 400w" sizes="(max-width: 2560px) 254px"
srcset="… 2x, … 254w, … 400w" sizes="(max-width: 2560px) 254px"
data-safe-src="data:image/gif;base64,…" />The other images in the same gallery (no profiler data) keep srcset="data:image/gif;base64,…".
Impact
- The E2E check
tests/e2e/envira.spec.ts › Gallery images all attributes replaced properlyhas failed on Firefox on 7 of the last 8developmentruns since 2026-10-12, including the release PR Release #1169. It started once the shared QA site's profile recorded missing-srcset data for attachment 18. Chromium passes only because its script timing is different. - Any plugin that keeps the real source in a
data-*-srcset/data-*-srcattribute (Envira, other galleries and lazy loaders) can get duplicated attributes or a placeholdersrcsetreplaced with eager candidates.
Root cause
inc/tag_replacer.php:
add_missing_srcset_attributes():strpos( $tag, 'srcset=' )/strpos( $tag, 'sizes=' )presence checks; srcset insert after/(src=["'][^"']*["'])/i; sizes insert after/(srcset=["'][^"']*["'])/i; existing-sizes lookup/sizes=…/.enhance_existing_srcset()/enhance_existing_sizes():preg_matchon/srcset=…/and/sizes=…/, thenpreg_replacewith no limit.
The code was introduced in 4.1.0 (8ab74741).
Proposed fix
- Match only the real
src/srcset/sizesattributes (attribute name preceded by whitespace) and replace a single occurrence. - When the real
srcset(orsrc) is adata:placeholder, another script owns loading the image: leave the tag unchanged instead of adding eager candidates. - PHPUnit cases for an Envira-style tag.
Activity
selul commentedon Oct 16, 2026
@pirate-bot test
selul commentedon Oct 16, 2026
@pirate-bot test
pirate-bot commentedon Oct 16, 2026
QA agent — 🔴 Has problems · Envira placeholders are preserved, but a data-src edge still misses srcset and sizes.
With a seeded Optimole account and local image delivery, the four-image Envira gallery keeps its placeholders and loads after scrolling in Chromium and Firefox. The original placeholder rewrite and duplicate sizes reproduce on the base build, not the candidate. A separate real-src image with a data: value in data-src still receives no srcset or sizes; that also fails on base. All 62 srcset tests pass, but their direct-method checks bypass this full-parser gap.
Problems found
❌ For ordinary non-placeholder images with profiler measurements, the image's own srcset and sizes are enhanced once without rewriting data- attributes, attribute-like text, or browser attribute boundaries.*
The representative normal image passes and 26 of 27 HTTP edge cases pass, including quote/alt/title boundaries, spaced/unquoted attributes, duplicates, noscript, cut-off values, malformed markup and JSON escaping. The added srcset PHPUnit class passes: 62 tests, 156 assertions; PHP 7.4 lint passes. One end-to-end failure remains: when data-src contains a data: GIF before a real own src, no own src
🐞 Existing bug: also fails on the base build. Not reported yet.
Worth a human look
Checks (2 passed)
Full report, evidence and session trail
fix: keep missing-srcset enhancement off data-* and lazy-load placeho…
pirate-bot commentedon Oct 19, 2026
🎉 This issue has been resolved in version 4.2.17 🎉
The release is available on GitHub release
Your semantic-release bot 📦🚀