Repository navigation
Description
Description
When an admin creates an Optimole account from the plugin dashboard (POST /optml/v1/register_service), Optml_Api::request() returns false if the API answers with an empty body, a non-JSON body (for example a proxy's HTML 502 page), JSON without a code key, or a non-200 code without an error key.
register_service() sends false into the same branch as WP_Error and calls $user->get_error_code() on it. This throws Error: Call to a member function get_error_code() on false. WordPress then returns a 500 "There has been a critical error on this website." and the dashboard shows its generic REST error instead of "Error creating account.".
Expected: when the API returns false, the endpoint should return the normal code: error response ("Error creating account."), as it did up to 3.11.3 and as connect() and select_application() already do.
Step-by-step reproduction instructions
- On a test site with Optimole 4.2.17 active and not connected, run this command. It fakes an empty 502 reply from the account API through
pre_http_request, so no real request is sent. Replace1with an administrator's user ID.wp eval ' add_filter( "pre_http_request", function ( $pre, $args, $url ) { return false !== strpos( $url, "complete_register_remote" ) ? [ "headers" => [], "body" => "", "response" => [ "code" => 502, "message" => "Bad Gateway" ], "cookies" => [], "filename" => null ] : $pre; }, 10, 3 ); wp_set_current_user( 1 ); $r = new WP_REST_Request( "POST", "/optml/v1/register_service" ); $r->set_param( "email", "qa@example.test" ); var_dump( rest_do_request( $r )->get_data() ); ' - Result:
PHP Fatal error: Uncaught Error: Call to a member function get_error_code() on false in .../inc/rest.php:468. - Expected: an array with
code => errorandmessage => "Error creating account.". - Same outcome without WP-CLI: I loaded the real
inc/api.phpandinc/rest.phpfrom v4.2.17 with WordPress functions stubbed and calledregister_service()with canned API bodies (PHP 8.4.19):== empty body == UNCAUGHT Error: Call to a member function get_error_code() on false at rest.php:468 == HTML 502 page from a proxy == UNCAUGHT Error: Call to a member function get_error_code() on false at rest.php:468 == JSON without code == UNCAUGHT Error: Call to a member function get_error_code() on false at rest.php:468 == JSON code 500, no error key == UNCAUGHT Error: Call to a member function get_error_code() on false at rest.php:468 == control: JSON code 400 with error == returned WP_REST_Response {"data":null,"message":"Error creating account. Some API error","code":"error"}
Screenshots, screen recording, code snippet or Help Scout ticket
false takes the WP_Error branch and is used as an object:
https://github.com/Codeinwp/optimole-wp/blob/v4.2.17/inc/rest.php#L467-L468
if ( $user === false || is_wp_error( $user ) ) {
if ( $user->get_error_code() === 'domain_not_accessible' ) {The same $user->get_error_message() call is repeated at https://github.com/Codeinwp/optimole-wp/blob/v4.2.17/inc/rest.php#L482.
The places where request() returns false:
https://github.com/Codeinwp/optimole-wp/blob/v4.2.17/inc/api.php#L180-L191 and https://github.com/Codeinwp/optimole-wp/blob/v4.2.17/inc/api.php#L217-L228
if ( empty( $response ) ) { return false; }
$response = json_decode( $response, true );
...
if ( ! isset( $response['code'] ) ) { return false; }The sibling handlers already guard the error-object calls with is_wp_error(): https://github.com/Codeinwp/optimole-wp/blob/v4.2.17/inc/rest.php#L377-L390
Core does not catch the error (call_user_func( $handler['callback'], $request ) in WP_REST_Server::respond_to_request(), wp-includes/rest-api/class-wp-rest-server.php:1293 in WordPress 7.1.3). The fatal handler answers with HTTP 500 (wp-includes/class-wp-fatal-error-handler.php:212).
A likely fix is to only call get_error_code() / get_error_message() when is_wp_error( $user ), and return the plain "Error creating account." response for false.
Environment info
- Optimole 4.2.17 (the code is the same on
masterat 63f3f7c) - Any WordPress version the plugin supports (5.5 and later; core lines cited from 7.1.3)
- PHP 7.4 and later. Calling a method on
falsethrowsErroron every PHP 7 and 8 version. Reproduced on PHP 8.4.19.
Is the issue you are reporting a regression
Yes. Up to 3.11.3, register_service() returned "Error creating account." for false without calling any method on it (https://github.com/Codeinwp/optimole-wp/blob/v3.11.3/inc/rest.php#L357-L366). The $user->get_error_code() call first ships in 3.12.0.
Found while writing the WordPress compatibility checks for Optimole.
Activity
girishpanchal30 commentedon Oct 29, 2026
I have fixed it with PR #1210
milicavs commentedon Oct 29, 2026
🧪 QA steps and test links
When Optimole's account service answers a sign-up with an empty or broken reply (for example a proxy's 502 page), creating an account from the Optimole dashboard crashes with a PHP fatal error. The dashboard then shows its generic "core REST API functionality is not available" banner instead of a normal "Error creating account." message.
Call to a member function get_error_code() on falsein the log8e82cd2In the links:
debug.log.Reproduce on Optimole 4.2.17 (with Optimole not connected):
add_filter( 'pre_http_request', function ( $pre, $args, $url ) { return false !== strpos( $url, 'complete_register_remote' ) ? [ 'headers' => [], 'body' => '', 'response' => [ 'code' => 502, 'message' => 'Bad Gateway' ], 'cookies' => [], 'filename' => null ] : $pre; }, 10, 3 );debug.log).PHP Fatal error: Uncaught Error: Call to a member function get_error_code() on false.Edge cases
'body' => '<html><body><h1>502 Bad Gateway</h1></body></html>'(HTML page): "Error creating account.", no fatal.{"code":400,"error":"Some API error"}: "Error creating account. Some API error".{"code":400,"error":"This email address is already registered."}: the "email is already registered" message, as before.Fix: #1210 (open)
pirate-bot commentedon Oct 29, 2026
QA agent — 🟢 Passing checks · Sign-up now handles broken API replies without crashing.
With Optimole disconnected and the account service mocked, all four reported bad replies—and eight extra malformed replies—returned the normal account error without crashing. The dashboard displayed the expected error, and normal API errors and website-access guidance stayed intact. The same sign-up action crashed on the base build but passed with this PR. The added tests passed all 8 cases and 22 assertions.
Worth a human look
Checks (3 passed)
Full report, evidence and session trail
pirate-bot commentedon Nov 2, 2026
🎉 This issue has been resolved in version 4.2.18 🎉
The release is available on GitHub release
Your semantic-release bot 📦🚀