Repository navigation
Fixed store above-fold background images #1240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
girishpanchal30
wants to merge
13
commits into
development
Choose a base branch
from
bugfix/1216
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
56209c9
fix: store above-fold background images
girishpanchal30 e785556
fix: record backgrounds for every matching watcher
girishpanchal30 ca7ee9f
fix: cap above-fold selectors per watcher
girishpanchal30 681af46
fix: cap background watchers
girishpanchal30 be2d283
fix: exempt every above-fold background
girishpanchal30 7cbde28
Fix: lint tests
girishpanchal30 b404f54
fix: optimize class name processing
girishpanchal30 3fc86e3
fix: use Lazyload constants for background selector limits
girishpanchal30 31b9037
fix: improve personalized CSS handling
girishpanchal30 0ece477
fix: enhance image detection and intersection observer handling
girishpanchal30 03ee02f
chore: update E2E tests to run on Ubuntu 24.04
girishpanchal30 d347841
fix: add test for recording queued entries in hidden tabs
girishpanchal30 1ad036a
fix: update image dimension detection to handle late-loading images
girishpanchal30 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testsThe timeout branch offlushIntersectionObserverhas no test. This case lets the jsdomrequestAnimationFramewin the race. It still passes ifsetTimeout(resolve, 100)is removed. That branch keeps profiling from waiting until a hidden tab is shown again, since hidden tabs render no frames. Add a case in thisdescribe. Calljest.useFakeTimers()first, then stubwindow.requestAnimationFramewith a function that never calls back. Fake timers replacerequestAnimationFrame, so the stub must come after them. Runawait jest.advanceTimersByTimeAsync(100), then expect the entry fromtakeRecordsinaboveTheFoldImagesandselectorMap. Restore real timers at the end.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. The new case
records queued entries when no frame is rendered, as in a hidden tabstubsrequestAnimationFrameafter the fake timers and advances 100 ms. It passes at HEAD1ad036a. With thesetTimeout(resolve, 100)arm removed fromflushIntersectionObserver, it fails withExceeded timeout of 5000 ms for a test.