Repository navigation
Conversation
optimole.com has no translated pages, but the plugin passed its links through tsdk_translate_link(), which puts the language code in the path for de, es, fr, it, ja, nl and ro users. Three upgrade links were translated twice and pointed to /de/de/upgrade, which is a 404. The upgrade, contact, home, pricing, terms, privacy and badge links now have no language code. Links to dashboard.optimole.com are unchanged. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin added a language code to optimole.com links for seven languages, and added it twice to three upgrade links (
/de/de/upgrade, a 404). optimole.com has no translated pages, so these links now have no language code.Note
The doubled code was added in 063d888 on version 4.1.3 (2025-11-05).
What changed
Upgrade link (
Optml_Admin::get_upgrade_base_link()): ishttps://optimole.com/upgrade/?email=…for every language. Before, a German admin gothttps://optimole.com/de/upgrade?email=….Upgrade notice in the Media Library, Black Friday sidebar offer, disabled-account notice: use the upgrade link as it is. Before, each one translated the link a second time and pointed to
/de/de/upgrade.Dashboard data (
optimoleHome,offload_upgrade_url,signup_terms): the home, pricing, terms and privacy links have no language code. The dashboard builds its footer and support links fromoptimoleHome, so those links change too.Contact link (
Optml_Admin::get_contact_base_link()): ishttps://optimole.com/contact/, with no language code and with a trailing slash.Frontend badge (
Optml_Manager::banner()): links tohttps://optimole.com/wordpress/?from=badgeOnfor every site language.Note
The seven languages are the ones that
tsdk_translate_link()knows: de, es, fr, it, ja, nl and ro.Links to
dashboard.optimole.comdo not change. Most of them carry the language as?lang=de. Two of them (dashboardURLandoptimoleDashMetrics) use the path mode, and this PR does not change them.Today optimole.com redirects most paths that have one language code to the page without the code. The home link is the exception:
/ja/is a 404, and/de/opens an unrelated page.The Black Friday sidebar offer is one of the three doubled links. This year the sale week starts on 2026-11-23.
QA
Use a site that is connected to an Optimole account on the free plan.
Go to
WP Admin → Settings → General(/wp-admin/options-general.php). Set Site Language to Deutsch. Save the settings.Expect: the admin is in German.
Create the file
wp-content/mu-plugins/optml-bf.phpwith the content below. Then go toWP Admin → Optimole(/wp-admin/admin.php?page=optimole).Expect: the upgrade box in the sidebar shows a black strip with the promo code
BFCM2525.Click that black strip.
Expect: the upgrade page opens, and its address starts with
https://optimole.com/upgrade/?email=. Before this change, the address started withhttps://optimole.com/de/de/upgradeand the page was a 404.Delete the file
wp-content/mu-plugins/optml-bf.php. Reload the Optimole page. Click the button in the upgrade box (View plans in English).Expect: the black strip is gone, and the upgrade page opens at an address that starts with
https://optimole.com/upgrade/?email=.In the page footer, click the first link. It shows the plugin name and version.
Expect: the Optimole home page opens at
https://optimole.com/. Before this change,https://optimole.com/de/opened an unrelated page.In the same footer, click each of the next three links.
Expect: the terms page, the privacy page and the test-drive page open. No address contains
/de/.Go to
WP Admin → Optimole → Settings → General(/wp-admin/admin.php?page=optimole#settings). Turn on the badge option (Enable Optimole Badge in English). Save the settings.Expect: the option stays on after a page reload.
Open the site home page in a private window. Copy the link address of the badge in the bottom corner.
Expect: the address is
https://optimole.com/wordpress/?from=badgeOn.🤖 Generated with Claude Code