Repository navigation
Description
Summary
Saving General settings can terminate with TypeError: Cannot access offset of type string on string when the submitted options structure contains a string where an array is expected. Invalid settings submissions are expected to be rejected without an uncaught exception. The captured failure aborts the settings-save request.
Customer context
- Product / area: LightStart, General settings save
- Version: 2.6.25
- Environment: PHP and WordPress versions not provided
- Reported error:
TypeError: Cannot access offset of type string on string - Impact: Settings-save request terminates
- Evidence: Error captured in two November 4 uninstall submissions; exact request bodies unavailable
Reproduction notes
Repository-derived reproduction, not executed: submit the authenticated settings-save action with tab=general, a valid tab-general nonce, and either string-valued options or string-valued options[general]. The source reaches the reported offset access after its existing guards. The actual captured payload and PHP version are unavailable.
Diagnosis
Conclusion
The captured General settings error matches a definite unchecked request-shape access in v2.6.25. This is source-backed confirmation, not an inference from the number of uninstall comments. The request body that produced the recorded error remains unknown.
Where this likely occurs
includes/classes/wp-maintenance-mode-admin.phplines 72–73,WP_Maintenance_Mode_Admin::__construct(): registerssave_plugin_settings()on the authenticated settings-save action.includes/classes/wp-maintenance-mode-admin.phplines 392–422,WP_Maintenance_Mode_Admin::save_plugin_settings(): checks capability, nonce, and tab membership, then directly accesses$_POST['options']['general']['status']without validating the container types. A string-valued container can produce the recorded TypeError at line 422.views/settings.phplines 85–94, General settings form: ordinary markup submits nestedoptions[general][status]fields.- Tagged v2.6.25 source matches the recorded line. Blame attributes the access to commit
72a22e07; the v2.6.24..v2.6.25 comparison leaves this handler unchanged, so no new regression is established.
Engineering notes
The failing value comes from POST data, not the persisted settings option. Reaching the access requires passing the existing capability, nonce, and tab checks. Normal form markup supplies an array-shaped payload; how the reported requests acquired a scalar container is unknown. No anonymous exploit or broader frontend failure is established. WordPress core was not runtime-verified.
Test coverage status
No relevant malformed-General-options coverage was found during inspection. tests/page-state-test.php lines 186–214, Test_Page_State::save_design_settings(), exercises a different settings branch with an array-shaped payload. PHP and Docker are unavailable in this environment, so tests and a local PHP reproduction were not run.
What to verify or explore next
- Reproduce an authenticated General save with a valid tab nonce and scalar
options, then with scalaroptions[general]. - Compare responses with an ordinary General form submission.
- Obtain the originating request shape and PHP version if available.
Unknowns / follow-up
The telemetry includes no request body or stack trace. The reason the malformed payload was submitted is not established.
Confidence
Confidence: 93/100
The captured error location matches an unchecked array-offset access in the affected release, with no request-container validation before it.
Source: automated uninstall feedback — wp-maintenance-mode, 2026-11-04
Generated by bug-report-triage (ID: bug-report-triage_6aec0d90cde642.94809936)
Activity
pirate-bot commentedon Nov 5, 2026
Another customer reported this via support.
Saving General settings can fail with a
TypeError: Cannot access offset of type string on stringwhen the submittedoptionsoroptions[general]structure is incorrectly passed as a string instead of an array. The root cause is an unchecked POST-container access located inWP_Maintenance_Mode_Admin::save_plugin_settings()withinincludes/classes/wp-maintenance-mode-admin.phparound line 422. To reproduce, submit the authenticated save action with sufficient capabilities and a valid nonce where theoptionscontainer is supplied as a string.Source: automated uninstall feedback — wp-maintenance-mode, 2026-11-04
Generated by bug-report-triage (ID: bug-report-triage_6aec0d90d68029.28608886)
girishpanchal30 commentedon Nov 5, 2026
I have fixed it with PR #600
rodica-andronache commentedon Nov 5, 2026
🧪 QA steps and test links
Saving LightStart's General settings crashes the site with "There has been a critical error on this website." when the request arrives with the settings sent as plain text instead of the usual form fields. Normal use of the form doesn't send that, but customers hit it, so the save must reject it cleanly instead of crashing.
TypeError: Cannot access offset of type string on string0b5ac3dIn the links:
wpsandbox.wordpress.net) in the DevTools console's context dropdown before step 3.debug.log.Reproduce on LightStart 2.6.25:
f=document.querySelector('#tab-general form');f.querySelectorAll('[name^="options"]').forEach(e=>e.removeAttribute('name'));f.insertAdjacentHTML('beforeend','<input type="hidden" name="options" value="status">');f.submit()Uncaught TypeError: Cannot access offset of type string on string.Edge cases
name="options[general]"instead ofname="options"in step 3: same Bug / Fixed result.Fix: #600 (open)
pirate-bot commentedon Nov 5, 2026
QA agent — 🟢 Passing checks · Malformed settings are rejected without crashing, and normal saves work.
The reported malformed General and Design requests returned an invalid-settings response without changing settings; the same requests crashed on the base build. Normal saves and the maintenance page worked on the test site. The added tests passed, with two existing edge observations noted for follow-up.
Worth a human look
0is a supported Exclude entry; both builds discard it.Checks (10 passed)
Full report, evidence and session trail
pirate-bot commentedon Nov 13, 2026
🎉 This issue has been resolved in version 2.6.26 🎉
The release is available on GitHub release
Your semantic-release bot 📦🚀