Open
Conversation
r6915ee
reviewed
Mar 19, 2026
Contributor
r6915ee
left a comment
There was a problem hiding this comment.
I'm noticing that the way the buffer is modified is done using large sections of code that can consist of up to ten lines using just the add method. I'd personally recommend iterating through every modification and applying it that way.
var buf:StringBuf = new StringBuf();
for (i in ["prefix", data, "suffix"])
buf.add(i);
Contributor
Author
Actually, in the |
Contributor
Author
|
I ended up writing a macro for this. It might make the code look a bit bloated, but it's definitely better than the previous approach. Of course, if there's a better way, feel free to let me know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
StringBufto reduce memory overhead from string concatenation.