fix: eliminate race condition in buildDSLDependency() for @-namespaced DSL#649
Merged
lmajano merged 1 commit intodevelopmentfrom Apr 2, 2026
Merged
Conversation
…d DSL Mutating the shared cached definition struct (arguments.definition.dsl) under concurrent load caused double-concatenation and mis-wiring when multiple threads resolved the same @-namespaced injection simultaneously (e.g. inject="myService@moduleName"). Instead of writing back to the shared struct, call getInstance() directly with the locally-computed concatenated name. The @-prefixed branch in getModelDSL() always resolves to a plain getInstance() call (no colons possible), so this is behaviourally identical but fully thread-safe. https://claude.ai/code/session_015kUgi5MyDwtH2FWf5u5DDN
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a concurrency bug in WireBox’s DSL dependency resolution when handling @-namespaced injections (e.g. inject="myService@moduleName"), avoiding mutation of a shared cached definition struct during concurrent resolution.
Changes:
- Stop mutating
arguments.definition.dslfor@-namespaced DSLs insidebuildDSLDependency(). - Resolve the computed namespaced mapping via a direct
injector.getInstance()call using a locally concatenated name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mutating the shared cached definition struct (arguments.definition.dsl)
under concurrent load caused double-concatenation and mis-wiring when
multiple threads resolved the same @-namespaced injection simultaneously
(e.g. inject="myService@moduleName").
Instead of writing back to the shared struct, call getInstance() directly
with the locally-computed concatenated name. The @-prefixed branch in
getModelDSL() always resolves to a plain getInstance() call (no colons
possible), so this is behaviourally identical but fully thread-safe.
https://claude.ai/code/session_015kUgi5MyDwtH2FWf5u5DDN