Automatically add 2 housing points when user passes spring evals#511
Open
pikachu0542 wants to merge 2 commits intodevelopfrom
Open
Automatically add 2 housing points when user passes spring evals#511pikachu0542 wants to merge 2 commits intodevelopfrom
pikachu0542 wants to merge 2 commits intodevelopfrom
Conversation
Member
Author
|
I have just realized that I have not accounted for if someone gets a conditional at spring evals and then passes when the conditional is evaluated. I will figure out how to handle that and make changes |
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Automatically adds 2 housing points when passing spring evals
Why
Im not entirely sure how housing points have been added in the past, but i ususally find that they dont get updated for a while (long after the end of the operating session, and i think also after evals presses the new year button). Instead of whatever else was previously done, now it is automatic.
If you pass, 2 points are added when evals presses the pass button on the slideshow. If you fail, housing points are not changed.
Test Plan
Not sure yet, need to figure this out (i dont know how to test this without modifying actual ldap data)
Env Vars
No
Documentation
I dont believe this change requires any documentation updates
Checklist