Skip to content

Limited poll title character length to 250#115

Open
FlyingCowMaster wants to merge 2 commits intoComputerScienceHouse:devfrom
FlyingCowMaster:dev
Open

Limited poll title character length to 250#115
FlyingCowMaster wants to merge 2 commits intoComputerScienceHouse:devfrom
FlyingCowMaster:dev

Conversation

@FlyingCowMaster
Copy link
Copy Markdown

What

The title for polls are now limited to 250 characters.

Why

To prevent polls with the bee movie script as their title.

Test Plan

I tried to put the bee movie script as a poll title. It was capped to 250 characters.

Env Vars

environment variables were not changed

Documentation

Documentation was unchanged.

Checklist

  • [X ] Tested all changes locally

@BigSpaceships
Copy link
Copy Markdown
Contributor

I left a note on slack, but this is fantastic!
It would be great if it also validated this on the backend too so people can't spoof requests and post bee movie scripts (because I know cole will). You don't have to do weird frontend error validation because the frontend already limits it so if someone's messing with the api they can suffer

Also don't worry about sonarqube failing

@FlyingCowMaster
Copy link
Copy Markdown
Author

I have added backend validation, so now if the title is too long it returns a bad request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants