Limited poll title character length to 250#115
Open
FlyingCowMaster wants to merge 2 commits intoComputerScienceHouse:devfrom
Open
Limited poll title character length to 250#115FlyingCowMaster wants to merge 2 commits intoComputerScienceHouse:devfrom
FlyingCowMaster wants to merge 2 commits intoComputerScienceHouse:devfrom
Conversation
Contributor
|
I left a note on slack, but this is fantastic! Also don't worry about sonarqube failing |
Author
|
I have added backend validation, so now if the title is too long it returns a bad request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The title for polls are now limited to 250 characters.
Why
To prevent polls with the bee movie script as their title.
Test Plan
I tried to put the bee movie script as a poll title. It was capped to 250 characters.
Env Vars
environment variables were not changed
Documentation
Documentation was unchanged.
Checklist