Repository navigation
fix(coverage): reconcile contradictory LCOV opener counts #538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
seonghobae
wants to merge
49
commits into
main
Choose a base branch
from
fix/contradictory-zero-count-records
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
625237e
fix(quality): align the hourly admission contract with central dispatch
seonghobae 016b98e
fix(actions): skip repository CI while a pull request is a draft
seonghobae 3687868
docs(agents): batch pushes while required checks are backlogged
seonghobae f0bed59
docs(agents): exempt merge-unblocking commits from push batching
seonghobae 6ff99a3
fix(coverage): count match arms whose body is one string literal
seonghobae 1645334
fix(coverage): count a function's success return
seonghobae c9f4aaf
merge: inherit coverage-denominator repair from #525
seonghobae 4279910
test(ci): pin draft-cancel and block-comment coverage regressions
seonghobae db49c16
fix(ci): cancel ready runs on draft conversion and retain block-comme…
seonghobae 3e43f26
test(coverage): pin inline-comment match-arm regression
seonghobae b733492
fix(coverage): preserve match arms with trailing line comments
seonghobae 575cc5c
fix(deps): clear the rustls TLS 1.3 handshake advisory
seonghobae 07b5dc0
test(coverage): close the block-comment classifier's coverage gaps
seonghobae 6469183
Merge remote-tracking branch 'origin/fix/hourly-central-admission-con…
seonghobae 21fc4c4
docs(changelog): keep one Unreleased section
seonghobae ab6a134
merge(ci): restack rustls advisory repair onto #523 successor
seonghobae ca74260
docs(security): remove false rustls CVE attribution
seonghobae d3d8199
test(coverage): expose leading block-comment arm gap
seonghobae 3ee73fd
fix(coverage): preserve arm labels after leading block comments
seonghobae c3767be
docs(coverage): restore decision comments around classifier logic
seonghobae 0419d0f
wip
seonghobae 40fed38
fix(coverage): drop zero counts a nested positive count disproves
seonghobae e19fbd5
test(coverage): preserve authored denominator during LCOV reconciliation
seonghobae 70afc4a
fix(coverage): reconcile contradictory opener counts without shrinkin…
seonghobae 20e593d
test(coverage): cover the unterminated block-comment opener branch
seonghobae 4f952c3
test(coverage): preserve commented block opener reconciliation
seonghobae 3647efb
fix(coverage): parse Rust comments before opener reconciliation
seonghobae a8b51c5
test(coverage): exercise Rust opener comment lexer branches
seonghobae 1fc9bc6
chore(stack): restack rustls advisory repair on current CI authority
seonghobae 961aaaf
chore(stack): inherit current CI and rustls security prerequisites
seonghobae bc6e585
test(coverage): preserve nested proof across non-authored trivia
seonghobae e2b0007
fix(coverage): reconcile opener zeros across non-authored trivia
seonghobae 00fbb83
test(coverage): reject literal-internal line-comment markers
seonghobae df38934
fix(coverage): classify only lexical Rust line comments
seonghobae c5189e1
test(coverage): expose block-comment authored-line gaps
seonghobae 1f9879c
test(coverage): correct RED helper reference
seonghobae 680790b
fix(coverage): preserve code after block comments
seonghobae 407eb5f
test(coverage): keep comment-wrapped braces structural
seonghobae d304335
fix(coverage): keep comment-wrapped braces structural
seonghobae dbe58f1
test(coverage): expose mixed block-line comment trivia gap
seonghobae 758e06d
fix(coverage): classify mixed block-line comment trivia
seonghobae 0a6947b
test(coverage): cover the opener with no measured line beneath it
seonghobae af3e0bc
test(security): reject writable cache after proposal apply
seonghobae 2424178
test(security): keep cache RED scoped to post-proposal persistence
seonghobae f335624
fix(security): remove verifier cache poisoning surface
seonghobae f4c32ce
fix(coverage): share Rust lexical state across authored line checks
seonghobae 5f070a6
test(coverage): exercise shared lexical boundary branches
seonghobae 3c349cf
Merge main into fix/contradictory-zero-count-records
seonghobae ed7f914
test(ci): reject split cache actions in proposal verifier
seonghobae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
경로 필터의 비교 범위를 수정해 주세요.
PR에서
scripts/check_coverage.py를 변경한 뒤AGENTS.md만 push해도ci.yml이 다시 실행되어 기존 실행을 취소할 수 있습니다. PR 경로 필터는 마지막 push가 아닌 PR 전체의 three-dot diff를 사용하기 때문입니다. (docs.github.com)PR 전체 diff가 경로 필터와 일치하지 않을 때 워크플로가 시작되지 않는다고 명시해 주세요. 현재 문구는 push할 때 기존 검사가 취소되지 않는다는 잘못된 판단을 유도할 수 있습니다.