🛡️ Sentinel: [CRITICAL] Fix missing authentication on admin endpoint

.jules/sentinel.md

@@ -32,3 +32,7 @@
 **Vulnerability:** The document hashing routine in `DefaultDocumentConversionService` processed file streams without enforcing any maximum size limit on the bytes read. An attacker could exploit this by uploading a maliciously large stream (or exploiting a compression bomb if unzipping), exhausting system memory, CPU, or disk space (DoS).
 **Learning:** Checking the declared file size (e.g., `file.getSize()`) in initial validation is not always sufficient if the input stream itself can be spoofed or dynamically expanded during reading. The actual bytes read must be verified against bounds continuously.
 **Prevention:** Always enforce a strict, configurable size limit (e.g., `ConversionProperties.maxUploadSizeBytes`) within the `while` loop that reads from untrusted input streams. Track `totalRead` and throw an exception immediately if the limit is exceeded.
+## 2026-08-16 - Missing authorization on AdminController endpoints
+**Vulnerability:** Admin controller endpoints lacked TenantAccessService authorization checks and did not verify tenant scope on returned jobs.
+**Learning:** Administrative endpoints were incorrectly assumed to be implicitly protected, allowing unauthenticated users to execute sensitive operations and potentially view cross-tenant jobs.
+**Prevention:** Always explicitly require a TenantContext via TenantAccessService even on admin routes, verify tenant boundary permissions using `job.belongsToTenant()`, and pseudonymize admin operator IDs.

src/main/java/com/clearfolio/viewer/controller/AdminController.java

@@ -1,20 +1,30 @@
 package com.clearfolio.viewer.controller;
 
+import java.nio.charset.StandardCharsets;
+import java.security.MessageDigest;
+import java.security.NoSuchAlgorithmException;
 import java.util.ArrayList;
+import java.util.HexFormat;
 import java.util.List;
+import java.util.Optional;
 import java.util.UUID;
 
+import org.springframework.http.HttpHeaders;
 import org.springframework.http.HttpStatus;
 import org.springframework.http.ResponseEntity;
 import org.springframework.web.bind.annotation.DeleteMapping;
 import org.springframework.web.bind.annotation.GetMapping;
 import org.springframework.web.bind.annotation.PathVariable;
 import org.springframework.web.bind.annotation.PostMapping;
+import org.springframework.web.bind.annotation.RequestHeader;
 import org.springframework.web.bind.annotation.RequestParam;
 import org.springframework.web.bind.annotation.RestController;
 import org.springframework.web.server.ResponseStatusException;
 
 import com.clearfolio.viewer.api.AdminJobListResponse;
+import com.clearfolio.viewer.auth.TenantAccessService;
+import com.clearfolio.viewer.auth.TenantContext;
+import com.clearfolio.viewer.auth.TenantPermissions;
 import com.clearfolio.viewer.model.ConversionJob;
 import com.clearfolio.viewer.service.DocumentConversionService;
 import com.clearfolio.viewer.service.RetryDeadLetterResult;
@@ -25,35 +35,56 @@
 @RestController
 public class AdminController {
 
+    /**
+     * Hex formatter for pseudonymization.
+     */
+    private static final HexFormat HEX_FORMAT = HexFormat.of();
+
+    /**
+     * Conversion service for administrative operations.
+     */
     private final DocumentConversionService conversionService;
 
+    /**
+     * Tenant and permission guard.
+     */
+    private final TenantAccessService tenantAccessService;
+
     /**
      * Creates a controller for admin operations.
      *
-     * @param conversionService conversion service
+     * @param service conversion service
+     * @param accessService tenant access service
      */
-    public AdminController(DocumentConversionService conversionService) {
-        this.conversionService = conversionService;
+    public AdminController(
+            final DocumentConversionService service,
+            final TenantAccessService accessService) {
+        this.conversionService = service;
+        this.tenantAccessService = accessService;
     }
 
     /**
      * Retrieves all conversion jobs, optionally filtered by dead-letter status.
      *
      * @param deadLettered optional filter for dead-lettered jobs
+     * @param headers request headers carrying tenant claims
      * @return list of conversion jobs
      */
     @GetMapping("/api/v1/admin/convert/jobs")
-    public AdminJobListResponse getAllJobs(@RequestParam(required = false) Boolean deadLettered) {
-        Iterable<ConversionJob> allJobs = conversionService.getAllJobs();
-
-        if (deadLettered == null) {
-            return AdminJobListResponse.from(allJobs);
-        }
+    public AdminJobListResponse getAllJobs(
+            @RequestParam(required = false) final Boolean deadLettered,
+            @RequestHeader final HttpHeaders headers) {
+        final TenantContext context = tenantAccessService.require(
+                headers, TenantPermissions.JOB_READ);
+        final Iterable<ConversionJob> allJobs = conversionService.getAllJobs();
 
-        List<ConversionJob> filtered = new ArrayList<>();
-        for (ConversionJob job : allJobs) {
-            if (job.isDeadLettered() == deadLettered) {
-                filtered.add(job);
+        final List<ConversionJob> filtered = new ArrayList<>();
+        for (final ConversionJob job : allJobs) {
+            if (job.belongsToTenant(context.tenantId())) {
+                if (deadLettered == null
+                        || job.isDeadLettered() == deadLettered) {
+                    filtered.add(job);
+                }
             }
         }
         return AdminJobListResponse.from(filtered);
@@ -63,29 +94,74 @@ public AdminJobListResponse getAllJobs(@RequestParam(required = false) Boolean d
      * Deletes a conversion job.
      *
      * @param jobId conversion job identifier
+     * @param headers request headers carrying tenant claims
      * @return no content on success
      */
     @DeleteMapping("/api/v1/admin/convert/jobs/{jobId}")
-    public ResponseEntity<Void> deleteJob(@PathVariable UUID jobId) {
-        conversionService.deleteJob(jobId);
+    public ResponseEntity<Void> deleteJob(
+            @PathVariable final UUID jobId,
+            @RequestHeader final HttpHeaders headers) {
+        final TenantContext context = tenantAccessService.require(
+                headers, TenantPermissions.JOB_DELETE);
+        if (!conversionService.deleteJob(
+                jobId, context)) {
+            throw new ResponseStatusException(
+                    HttpStatus.NOT_FOUND, "job not found");
+        }
         return ResponseEntity.noContent().build();
     }
 
     /**
      * Retries a dead-lettered conversion job.
      *
      * @param jobId conversion job identifier
+     * @param headers request headers carrying tenant claims
      * @return accepted response on success
+     * @throws NoSuchAlgorithmException if hashing fails
      */
     @PostMapping("/api/v1/admin/convert/jobs/{jobId}/retry")
-    public ResponseEntity<Void> retryDeadLettered(@PathVariable UUID jobId) {
-        RetryDeadLetterResult result = conversionService.retryDeadLettered(jobId, "admin");
+    public ResponseEntity<Void> retryDeadLettered(
+            @PathVariable final UUID jobId,
+            @RequestHeader final HttpHeaders headers)
+            throws NoSuchAlgorithmException {
+        final TenantContext context = tenantAccessService.require(
+                headers, TenantPermissions.JOB_RETRY);
+        final Optional<ConversionJob> job = conversionService.getJob(jobId);
+        if (job.isEmpty()
+                || !job.get().belongsToTenant(context.tenantId())) {
+            throw new ResponseStatusException(
+                    HttpStatus.NOT_FOUND, "job not found");
+        }
+
+        final String operatorId =
+                hashOperatorId(context.subjectId());
+        final RetryDeadLetterResult result =
+                conversionService.retryDeadLettered(
+                jobId, operatorId);
         if (result == RetryDeadLetterResult.NOT_FOUND) {
-            throw new ResponseStatusException(HttpStatus.NOT_FOUND, "job not found");
+            throw new ResponseStatusException(
+                    HttpStatus.NOT_FOUND, "job not found");
         }
         if (result == RetryDeadLetterResult.NOT_ELIGIBLE) {
-            throw new ResponseStatusException(HttpStatus.CONFLICT, "job is not eligible for retry");
+            throw new ResponseStatusException(
+                    HttpStatus.CONFLICT,
+                    "job is not eligible for retry");
         }
         return ResponseEntity.accepted().build();
     }
+
+    /**
+     * Hashes the subject ID for audit logging.
+     *
+     * @param subjectId subject identifier
+     * @return hex encoded SHA-256 hash
+     * @throws NoSuchAlgorithmException if hashing fails
+     */
+    private String hashOperatorId(final String subjectId)
+            throws NoSuchAlgorithmException {
+        final MessageDigest digest = MessageDigest.getInstance("SHA-256");
+        final byte[] hash = digest.digest(
+                subjectId.getBytes(StandardCharsets.UTF_8));
+        return HEX_FORMAT.formatHex(hash);
+    }
 }