Repository navigation
fix: fire the command event for finished prompt commands - #106
Merged
Merged
Conversation
Plugins that watch typed commands (alerts, logs) now see commands that went through a prompt.
- Treat a listener cancel as cancelled: run ON_CANCEL actions and skip the error message, instead of reporting the command as completed. - Fire the event before granting attachment permissions, and run a rewritten command as the plain player. - Fire the event for the primary command only, not preset actions the player never typed. - Show the command that actually ran in the completed message. - Track the bridge's own event instead of a per-thread flag.
Owner
|
Thanks for this! I pushed a follow-up commit (05edabe) to your branch after reviewing it:
Added tests for attachment mode, the immediate dispatcher and the coordinator. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a command has a prompt, the original
PlayerCommandPreprocessEventis cancelled and the finished command later runs throughBukkit.dispatchCommand, which fires no command event. Plugins that react to typed commands (e.g. DiscordSRV alerts, command loggers) never see these commands.PlayerCommandPreprocessEventfor the finished command before player dispatch (primary and immediate actions). A listener can rewrite the message or cancel it, like for a typed command.<...>never open a new prompt.