Skip to content

Assorted structure fixes for 53.11#880

Open
quietust wants to merge 1 commit intoDFHack:masterfrom
quietust:fixes
Open

Assorted structure fixes for 53.11#880
quietust wants to merge 1 commit intoDFHack:masterfrom
quietust:fixes

Conversation

@quietust
Copy link
Member

@quietust quietust commented Mar 17, 2026

The following changes may potentially impact plugins or scripts (if any are actually using them):

  • viewscreen_worldst.squad_flag now uses new bitfield civlist_squad_flag
  • viewscreen_worldst.messenger_flag now uses new bitfield civlist_messenger_flag
  • adventure_movement_movest.aim_attack_flag now uses aim_attack_flag bitfield
  • adventure_constructionst.building_jobitemflag now uses job_material_category bitfield
  • adventure_constructionst.mat_jobitemflag now uses job_material_category bitfield
  • adventure_constructionst.mat_jobitemflag_master now uses job_material_category bitfield
  • custom_stockpile_interfacest.cur_main_mode_flag now uses stockpile_group_set bitfield
  • custom_stockpile_interfacest.main_mode_flag now uses stockpile_group_set bitfield
  • dance_form_section.dance_flag now uses dance_flag bitfield
  • historical_entity.resources.scholar_flag now uses entity_scholar_flag bitfield
  • interaction_effect_change_weatherst fields add_weather_flag and remove_weather_flag now use region_weather_bits bitfield
  • site_construction_blueprintst fields construction_jobitemflag and building_jobitemflag now use job_material_category bitfield

@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2026

The sizes of the following types have changed in this pull request. Please verify that this is intentional. Note that renamed types are not currently detected and will also be listed here.

Type Platform Previous size New size (this PR) Change
civlist_messenger_flag linux64 0 4 +4
civlist_messenger_flag windows64 0 4 +4
civlist_squad_flag linux64 0 4 +4
civlist_squad_flag windows64 0 4 +4
construction_type linux64 2 4 +2
construction_type windows64 2 4 +2
entity_art_image_type linux64 0 2 +2
entity_art_image_type windows64 0 2 +2
inclusion_type linux64 4 2 -2
inclusion_type windows64 4 2 -2
lookinfo_verminst linux64 20 16 -4
lookinfo_verminst windows64 20 16 -4
pmd_tree_texture_infost linux64 1596 2044 +448
pmd_tree_texture_infost windows64 1596 2044 +448
title_mode_type linux64 0 4 +4
title_mode_type windows64 0 4 +4
viewport_spatter_flag linux64 8 4 -4
viewport_spatter_flag windows64 8 4 -4

This is an automated comment. Please leave a reply if you think that the above information is incorrect.

@quietust
Copy link
Member Author

The change to spatter_graphics_infost is unexpected - apparently, codegen is ignoring the base-type attribute on <bitfield>.

@quietust quietust force-pushed the fixes branch 2 times, most recently from fa05357 to e252b68 Compare March 17, 2026 03:16
changelog.txt Outdated
- specific changes: ``adventure_constructionst.building_jobitemflag`` now uses ``job_material_category`` bitfield
- specific changes: ``adventure_constructionst.mat_jobitemflag`` now uses ``job_material_category`` bitfield
- specific changes: ``adventure_constructionst.mat_jobitemflag_master`` now uses ``job_material_category`` bitfield
- specific changes: ``building_defst.build_key` now uses ``interface_key`` enum
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing backquote here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, along with another one further down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants