Merged
Conversation
Add retry logic with exponential backoff to Spark wallet initialization (5 attempts, 2s-30s delays) and a global uncaughtException handler that catches Spark SDK WASM-layer crashes without terminating the process. The Spark SDK can throw uncatchable exceptions from its native gRPC/WASM layer (SparkAuthenticationError) when the Spark network is unreachable, which bypasses try/catch and kills the Node.js process.
github-actions
bot
requested review from
TaprootFreak and
davidleomay
as code owners
The Spark SDK can throw uncatchable errors from its WASM/gRPC layer via timer callbacks, leaving SparkWallet.initialize() hanging as an unresolved promise. This causes all Spark operations to block forever. - Add 60s timeout per initialization attempt so hanging promises fail and the retry loop can continue - Extract initializeWithTimeout() to race initialization against timer - Add resetWallet() method for external recovery triggers - Improve uncaughtException handler readability
TaprootFreak
approved these changes
Apr 9, 2026
Author
❌ Security: 3 critical vulnerabilities |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic Release PR
This PR was automatically created after changes were pushed to develop.
Commits: 1 new commit(s)
Checklist