Repository navigation
fix: restore Settings/Admin access and demo readiness - #48
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 383c2c19c8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Profile Settings and the Admin Console pointed to missing routes despite existing screen/backend implementations. This repair connects validated existing account/admin RPCs, gates access by current server capabilities, restores server workspace defaults, and replenishes the admin queue after each saved moderation decision.
Closes #47. Full hosted authentication and physical-device acceptance remains #46. Completed M03A issue #4 is closed separately; PR #45 already merged. Video generation is outside this follow-up.
Changes
Verification
Fresh source
67b6c77: formatting, ESLint, strict TypeScript, 115 suites/718 tests, Expo Doctor 20/20 and Android Hermes export 5.3MB pass. Source CI 41586631382 passed app, database migrations/policies and GitGuardian. Independent final code and documentation reviews: LGTM. Both automated review threads resolved after fixes and regression verification. Test-first evidence includes the initially failing first-page replenishment regression. Secret-exposure tests and staged diff checks pass. Final docs-only commit099f834leaves application source unchanged; final head CI 41588486940 passed app and database checks, with GitGuardian also green.APK and emulator evidence
Both locally built standalone APKs are 60,496,430 bytes, support ARM64+x86_64, embed JS/assets and passed v2 signature and private-credential/archive scans. Ignored artifacts:
Both final APK installs succeeded on isolated do_well_demo_api35 (Android 15/API 35/x86_64), cold launch without Metro: 3.067s offline / 3.858s live. Offline new post→apply→select→text submit→approve→reset passed with airplane mode on and Wi-Fi/mobile data off, visible completed assignment/timeline. Live existing authorized employer email sign-in, redesigned Home, Profile→Settings, server default save and original-default restore passed. No new account or admin grant. Both rehearsal processes exited 0. Full commands, source manifest, hashes, logs and screenshots are recorded in docs/DEMO_GUIDE.md; prepared emulator is left on the live APK, online and signed in. The old full medium_phone AVD's data was preserved.
Screenshots
Actual ignored local evidence: apk-demo-first-launch.png, apk-demo-lifecycle-complete.png, apk-live-home.png, apk-live-settings.png, apk-live-settings-saved.png under .codex-artifacts/. Code reviewer and root inspected screenshots/logs; reviewer independently recomputed hashes.
Security, cost and limits
No schema/RLS/hosted provisioning/capability grant/billing change. Existing SQL RPCs enforce authority. No private credentials, signing material or APKs tracked; owner .gitignore/expo-env.d.ts modifications preserved. PHP 0 / USD 0, local Android SDK only. Development signing is for controlled sideloading, not store publication. No connected physical phone or fresh local HTTP integration (Docker unavailable). Offline does not establish hosted RLS/OAuth/photo/GPS acceptance; one email sign-in/settings path does not close the full multi-principal/device matrix. Default brief assistance is deterministic; no payment, ratings or automatic queued-write synchronization claim.