Show parameter display names instead of keys across schema forms, run results, and explorer details#677
Open
Irozuku wants to merge 3 commits into
Open
Show parameter display names instead of keys across schema forms, run results, and explorer details#677Irozuku wants to merge 3 commits into
Irozuku wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parameter labels in the frontend now show a single human readable display name instead of both the display name and the raw key. The schema field card, the run results parameter table, and the explorer details parameters tab all resolve each parameter's display name from schema data that is already loaded, so no extra backend calls are made.
Type of Change
Changes (by file)
DashAI/front/src/components/shared/FormSchemaFieldCard.jsx: Header now renders onlylabel ?? paramKey(display name, falling back to the key). Removed the separate monospace key line so each schema field shows one label.DashAI/front/src/components/models/RunCard.jsx: Pass the matchedmodel(already resolved from the right side bar list) down toRunResults.DashAI/front/src/components/models/RunResults.jsx: Accept themodelprop and map each run parameter key to its display name viamodel.schema.properties[key].title, falling back to the key. No extra fetch.DashAI/front/src/components/notebooks/explorer/ExplorerDetailsModal.jsx: PassexplorerComponent.schemainto the parameters tab.DashAI/front/src/components/notebooks/explorer/tabs/Parameters.jsx: Accept aschemaprop and resolve each parameter's display name fromschema.properties[key].title, falling back to the key.Testing