Skip to content

[WIP] fix(cold_start): capture trace context before finishing spans #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jchrostek-dd wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[WIP] fix(cold_start): capture trace context before finishing spans #746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions datadog_lambda/wrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,16 @@ def _after(self, event, context):

status_code = extract_http_status_code_tag(self.trigger_tags, self.response)

# Skip creating cold start spans in managed instances mode
# In managed instances, the tracer library handles cold start independently
should_trace_cold_start = (
config.cold_start_tracing
and is_new_sandbox()
and not is_managed_instances_mode()
)
if should_trace_cold_start:
trace_ctx = tracer.current_trace_context()

if self.span:
if config.appsec_enabled and not self.blocking_response:
asm_start_response(
Expand Down Expand Up @@ -342,15 +352,6 @@ def _after(self, event, context):
create_dd_dummy_metadata_subsegment(
self.trigger_tags, XraySubsegment.LAMBDA_FUNCTION_TAGS_KEY
)
# Skip creating cold start spans in managed instances mode
# In managed instances, the tracer library handles cold start independently
should_trace_cold_start = (
config.cold_start_tracing
and is_new_sandbox()
and not is_managed_instances_mode()
)
if should_trace_cold_start:
trace_ctx = tracer.current_trace_context()

if self.inferred_span:
if status_code:
Expand Down
7 changes: 6 additions & 1 deletion tests/test_cold_start.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,13 +310,18 @@ def handler(event, context):
handler.cold_start_tracing = True
handler({}, lambda_context)

function_span = import_span = None
function_span = import_span = load_span = None
for span in spans:
if span.resource == "tabnanny":
import_span = span
elif span.name == "aws.lambda":
function_span = span
elif span.name == "aws.lambda.load":
load_span = span

assert function_span is not None
assert import_span is not None
assert import_span.parent_id == function_span.span_id
assert import_span.trace_id == function_span.trace_id
assert load_span is not None
assert load_span.trace_id == function_span.trace_id
Loading