libdatadog update to 42d9ab04#3927
Conversation
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 269af891ab
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -1 +1 @@ | |||
| Subproject commit cea1e44edddd9124f75d5095f31026904a1f58d8 | |||
| Subproject commit 8ac735802ccd4eca304019be37960183a19bdaeb | |||
There was a problem hiding this comment.
Update Rust toolchains with this submodule bump
In environments that use this repo's pinned Rust 1.84.1 (Cargo.toml, profiling/rust-toolchain.toml, and the CI Dockerfiles), this new libdatadog SHA cannot be compiled because libdatadog at 8ac735802ccd4eca304019be37960183a19bdaeb declares workspace.package.rust-version = "1.87.0". Since profiling/Cargo.toml depends on libdatadog path crates, Cargo rejects the dependency before building; the toolchain/manifests/images need to be bumped alongside this gitlink, or the previous SHA kept.
Useful? React with 👍 / 👎.
269af89 to
578859b
Compare
578859b to
f75861e
Compare
f75861e to
405c9b4
Compare
Benchmarks [ profiler ]Benchmark execution time: 2026-05-30 02:40:12 Comparing candidate commit 405c9b4 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 7 unstable metrics. |
Automated update by CI pipeline https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-php/-/pipelines/116097661 Full CI result: ❌ 12 job(s) failed
405c9b4 to
2dc0884
Compare
Summary
Automated update of the libdatadog submodule to the latest HEAD.
cea1e44edddd9124f75d5095f31026904a1f58d842d9ab0438338516d2e8ef962de4f8ed158c519dFull CI result: ❌ 12 job(s) failed
CI pipeline: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-php/-/pipelines/116097661
libdatadog Integration Report
libdatadog SHA: 42d9ab0438338516d2e8ef962de4f8ed158c519d
Analysis date: 2026-05-30
Overall status
❌ Blocking issues remain — but the blocker is CI/git infrastructure, not a libdatadog
API incompatibility. The build never ran, so API compatibility could not be evaluated.
Build & test summary
12 jobs failed across the package, profiler, and tracer sub-pipelines:
compile tracing extension(7.0/7.1/7.2/7.3/7.4/8.0/8.2/8.4 across amd64 + arm64)compile profiler extension(8.1 amd64, 8.5 amd64)aggregate tested versions(tracer-trigger)Every one of the 11
compile …jobs failed at the exact same step, before any Rustcompilation began. After checking out the libdatadog submodule at the in-tree pin
cea1e44edddd9124f75d5095f31026904a1f58d8, the CI step tries to shallow-fetch the targetSHA and aborts:
No trace contains any
Compiling …,cargo,rustc, or Rust compiler diagnostic(
error[E…],no method,unresolved import, mismatched types, etc.). The jobs neverreached the build.
git fetch-pack: expected shallow listis a git transport-layer error(the remote did not return a well-formed shallow-info response for the
--depth=1fetch);it is independent of the contents of the libdatadog repository — the target commit exists
and is in fact the tip of the changelog (
42d9ab043 fix(otlp): propagate _dd.p.tid …).The 12th failure,
aggregate tested versions, has no compilation trace and is atracer-trigger aggregation job; with all upstream compile jobs failing on the same infra
issue, it is a downstream cascade of the same root cause (no libdatadog signal).
Non-trivial changes made
No code changes required.
The failures are not API breakages — they are a CI git-fetch infrastructure problem that
prevented compilation entirely. There are no compiler errors to adapt to, and making
speculative source edits without a real build signal would risk breaking a currently-working
integration. The dd-trace-php Rust sources were left untouched. (The only working-tree change
is the expected
M libdatadogsubmodule pointer bump to the SHA under analysis.)Identified libdatadog issues
None identified.
The libdatadog code at
42d9ab0438…was never compiled or executed by CI, so no libdatadogbug or behavioural regression can be attributed from this run.
fetch step, the following breaking changes (
!) present in the changelog since the pinnedSHA remain un-validated against dd-trace-php and should be watched once the fetch issue is
resolved and a real build runs:
1fb8aca2f feat!: Align tracer FFI error and response types with common conventions (#2029)2a659a6eb fix(crashtracking)!: flatten all threads object into a list of ThreadData (#2054)f7d471dc5 feat(trace-utils)!: introduce VecMap datastructure (#2022)ecdca7d4e feat(trace-utils)!: add from_string to span text (#2011)e2fb8860d feat!: add encoder from v04 to v1 (#1896)Flaky / ignored failures
All 12 failures are classified as infrastructure / unrelated to libdatadog API:
compile …jobs failed onfatal: git fetch-pack: expected shallow listduringthe
git fetch --depth=1 origin <SHA>submodule step — a git/transport infrastructureissue, not a code or API problem. Re-running once the CI git cache / fetch path is healthy
(or using a full fetch instead of
--depth=1) is the appropriate remediation.aggregate tested versionsproduced no compilation trace and is a downstream aggregationof the above; no independent signal.
Recommended action: this is a re-run / CI-infrastructure fix, not a source adaptation.
A genuine API-compatibility assessment requires a pipeline where the libdatadog submodule
fetch succeeds.
/cc @bwoebi