Skip to content

libdatadog update to 42d9ab04#3927

Open
dd-octo-sts[bot] wants to merge 1 commit into
masterfrom
bot/libdatadog-latest
Open

libdatadog update to 42d9ab04#3927
dd-octo-sts[bot] wants to merge 1 commit into
masterfrom
bot/libdatadog-latest

Conversation

@dd-octo-sts
Copy link
Copy Markdown
Contributor

@dd-octo-sts dd-octo-sts Bot commented May 28, 2026

Summary

Automated update of the libdatadog submodule to the latest HEAD.

SHA
Previous cea1e44edddd9124f75d5095f31026904a1f58d8
New 42d9ab0438338516d2e8ef962de4f8ed158c519d

Full CI result: ❌ 12 job(s) failed
CI pipeline: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-php/-/pipelines/116097661


libdatadog Integration Report

libdatadog SHA: 42d9ab0438338516d2e8ef962de4f8ed158c519d
Analysis date: 2026-05-30

Overall status

❌ Blocking issues remain — but the blocker is CI/git infrastructure, not a libdatadog
API incompatibility. The build never ran, so API compatibility could not be evaluated.

Build & test summary

12 jobs failed across the package, profiler, and tracer sub-pipelines:

  • 9 × compile tracing extension (7.0/7.1/7.2/7.3/7.4/8.0/8.2/8.4 across amd64 + arm64)
  • 2 × compile profiler extension (8.1 amd64, 8.5 amd64)
  • 1 × aggregate tested versions (tracer-trigger)

Every one of the 11 compile … jobs failed at the exact same step, before any Rust
compilation began.
After checking out the libdatadog submodule at the in-tree pin
cea1e44edddd9124f75d5095f31026904a1f58d8, the CI step tries to shallow-fetch the target
SHA and aborts:

$ git config --global --add safe.directory "${CI_PROJECT_DIR}/libdatadog"
$ (cd libdatadog; git fetch --depth=1 origin "42d9ab0438338516d2e8ef962de4f8ed158c519d" 2>&1)
fatal: git fetch-pack: expected shallow list
ERROR: Job failed: command terminated with exit code 1

No trace contains any Compiling …, cargo, rustc, or Rust compiler diagnostic
(error[E…], no method, unresolved import, mismatched types, etc.). The jobs never
reached the build. git fetch-pack: expected shallow list is a git transport-layer error
(the remote did not return a well-formed shallow-info response for the --depth=1 fetch);
it is independent of the contents of the libdatadog repository — the target commit exists
and is in fact the tip of the changelog (42d9ab043 fix(otlp): propagate _dd.p.tid …).

The 12th failure, aggregate tested versions, has no compilation trace and is a
tracer-trigger aggregation job; with all upstream compile jobs failing on the same infra
issue, it is a downstream cascade of the same root cause (no libdatadog signal).

Non-trivial changes made

No code changes required.

The failures are not API breakages — they are a CI git-fetch infrastructure problem that
prevented compilation entirely. There are no compiler errors to adapt to, and making
speculative source edits without a real build signal would risk breaking a currently-working
integration. The dd-trace-php Rust sources were left untouched. (The only working-tree change
is the expected M libdatadog submodule pointer bump to the SHA under analysis.)

Identified libdatadog issues

None identified.

The libdatadog code at 42d9ab0438… was never compiled or executed by CI, so no libdatadog
bug or behavioural regression can be attributed from this run.

⚠️ Caveat — API compatibility was NOT verified. Because the build was blocked at the
fetch step, the following breaking changes (!) present in the changelog since the pinned
SHA remain un-validated against dd-trace-php and should be watched once the fetch issue is
resolved and a real build runs:

  • 1fb8aca2f feat!: Align tracer FFI error and response types with common conventions (#2029)
  • 2a659a6eb fix(crashtracking)!: flatten all threads object into a list of ThreadData (#2054)
  • f7d471dc5 feat(trace-utils)!: introduce VecMap datastructure (#2022)
  • ecdca7d4e feat(trace-utils)!: add from_string to span text (#2011)
  • e2fb8860d feat!: add encoder from v04 to v1 (#1896)

Flaky / ignored failures

All 12 failures are classified as infrastructure / unrelated to libdatadog API:

  • The 11 compile … jobs failed on fatal: git fetch-pack: expected shallow list during
    the git fetch --depth=1 origin <SHA> submodule step — a git/transport infrastructure
    issue, not a code or API problem. Re-running once the CI git cache / fetch path is healthy
    (or using a full fetch instead of --depth=1) is the appropriate remediation.
  • aggregate tested versions produced no compilation trace and is a downstream aggregation
    of the above; no independent signal.

Recommended action: this is a re-run / CI-infrastructure fix, not a source adaptation.
A genuine API-compatibility assessment requires a pipeline where the libdatadog submodule
fetch succeeds.


/cc @bwoebi

@dd-octo-sts dd-octo-sts Bot requested a review from a team as a code owner May 28, 2026 02:23
@datadog-official
Copy link
Copy Markdown

datadog-official Bot commented May 28, 2026

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 253 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-php | Cargo test   View in Datadog   GitLab

🔧 Fix in code (Fix with Cursor). Use of unstable library feature 'unsigned_is_multiple_of' in libdatadog/libdd-profiling/src/internal/profile/interning_api/mod.rs:237

DataDog/apm-reliability/dd-trace-php | ZAI Shared Tests: [7.4]   View in Datadog   GitLab

🔧 Fix in code (Fix with Cursor). Compilation error: std::string::String::as_bytes is not yet stable as a const fn in libdatadog/libdd-trace-obfuscation/src/sql.rs:278. Add #![feature(const_vec_string_slice)] to enable.

DataDog/apm-reliability/dd-trace-php | ZAI Shared Tests: [8.0]   View in Datadog   GitLab

🔧 Fix in code (Fix with Cursor). Compilation error in libdatadog/libdd-trace-obfuscation/src/sql.rs:278: const fn 'std::string::String::as_bytes' is not yet stable. Add '#![feature(const_vec_string_slice)]' to enable.

View all 253 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2dc0884 | Docs | Datadog PR Page | Give us feedback!

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 269af891ab

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread libdatadog Outdated
@@ -1 +1 @@
Subproject commit cea1e44edddd9124f75d5095f31026904a1f58d8
Subproject commit 8ac735802ccd4eca304019be37960183a19bdaeb
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Update Rust toolchains with this submodule bump

In environments that use this repo's pinned Rust 1.84.1 (Cargo.toml, profiling/rust-toolchain.toml, and the CI Dockerfiles), this new libdatadog SHA cannot be compiled because libdatadog at 8ac735802ccd4eca304019be37960183a19bdaeb declares workspace.package.rust-version = "1.87.0". Since profiling/Cargo.toml depends on libdatadog path crates, Cargo rejects the dependency before building; the toolchain/manifests/images need to be bumped alongside this gitlink, or the previous SHA kept.

Useful? React with 👍 / 👎.

@dd-octo-sts dd-octo-sts Bot changed the title libdatadog update to 8ac73580 libdatadog update to f7d471dc May 28, 2026
@dd-octo-sts dd-octo-sts Bot force-pushed the bot/libdatadog-latest branch from 269af89 to 578859b Compare May 28, 2026 16:34
@dd-octo-sts dd-octo-sts Bot requested review from a team as code owners May 28, 2026 16:34
@dd-octo-sts dd-octo-sts Bot requested review from greghuels and leoromanovsky and removed request for a team May 28, 2026 16:34
@dd-octo-sts dd-octo-sts Bot changed the title libdatadog update to f7d471dc libdatadog update to 2a659a6e May 29, 2026
@dd-octo-sts dd-octo-sts Bot force-pushed the bot/libdatadog-latest branch from 578859b to f75861e Compare May 29, 2026 03:04
@dd-octo-sts dd-octo-sts Bot changed the title libdatadog update to 2a659a6e libdatadog update to 42d9ab04 May 30, 2026
@dd-octo-sts dd-octo-sts Bot force-pushed the bot/libdatadog-latest branch from f75861e to 405c9b4 Compare May 30, 2026 02:23
@dd-octo-sts dd-octo-sts Bot requested review from a team as code owners May 30, 2026 02:23
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented May 30, 2026

Benchmarks [ profiler ]

Benchmark execution time: 2026-05-30 02:40:12

Comparing candidate commit 405c9b4 in PR branch bot/libdatadog-latest with baseline commit 095538e in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 7 unstable metrics.

@dd-octo-sts dd-octo-sts Bot force-pushed the bot/libdatadog-latest branch from 405c9b4 to 2dc0884 Compare May 31, 2026 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants