feat(shared-runtime)!: use weak waker in trigger#2050
Conversation
📚 Documentation Check Results📦
|
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 28fc7ca | Docs | Datadog PR Page | Give us feedback! |
🔒 Cargo Deny Results📦
|
Co-authored-by: paullegranddc <82819397+paullegranddc@users.noreply.github.com>
c8bba74 to
28fc7ca
Compare
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2050 +/- ##
==========================================
+ Coverage 72.90% 73.06% +0.16%
==========================================
Files 457 461 +4
Lines 75768 76521 +753
==========================================
+ Hits 55238 55913 +675
- Misses 20530 20608 +78
🚀 New features to boost your workflow:
|
What does this PR do?
Wrap the trigger future waker to use a weak reference on the runtime. This allows the runtime to be dropped and properly shutdown when calling
before_forkMotivation
When reading from a channel in the trigger method, the waker being held by the channel can prevent the tokio driver from being dropped when calling
before_forkwhich can cause crashes in macos as the kqueue handle becomes invalid in the child process.Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.