Use canonical FFE fixtures#275
Draft
leoromanovsky wants to merge 3 commits into
Draft
Conversation
sameerank
added a commit
that referenced
this pull request
May 12, 2026
- Add standalone unit test for evaluateForSubject verifying serialId passthrough to flagMetadata.__dd_split_serial_id - Revert fixture changes (flags-v1.json, test-case-numeric-flag.json) to avoid merge conflicts with PR #275 removing JSON fixtures - Remove fixture-dependent assertion from flags-v1.spec.ts
sameerank
added a commit
that referenced
this pull request
May 12, 2026
- Add standalone unit test for evaluateForSubject verifying serialId passthrough to flagMetadata.__dd_split_serial_id - Revert fixture changes (flags-v1.json, test-case-numeric-flag.json) to avoid merge conflicts with PR #275 removing JSON fixtures - Remove fixture-dependent assertion from flags-v1.spec.ts
sameerank
added a commit
that referenced
this pull request
May 12, 2026
* feat(node): expose serialId in flagMetadata for span enrichment * test(node): add unit tests for serialId passthrough in flagMetadata - Add serialId to numeric_flag split in test fixture - Add test assertion verifying serialId is passed through to flagMetadata - Update node-server to use workspace dependency for flagging-core so tests run against local types with serialId field * Rename serialId to __dd_split_serial_id in flagMetadata * Add standardized __dd_ prefixed keys to flagMetadata (#273) * Add __dd_allocation_key and __dd_do_log, deprecate old keys * Remove fallbacks from internal readers * test(node): add unit test for serial ID, revert fixture changes - Add standalone unit test for evaluateForSubject verifying serialId passthrough to flagMetadata.__dd_split_serial_id - Revert fixture changes (flags-v1.json, test-case-numeric-flag.json) to avoid merge conflicts with PR #275 removing JSON fixtures - Remove fixture-dependent assertion from flags-v1.spec.ts * revert: remove __dd_ keys from browser package Keep __dd_ prefixed keys only in node-server package. The browser SDK uses precomputed assignments and doesn't need the standardized keys that are intended for span enrichment in server-side tracing. * fix: keep original keys as primary, __dd_ keys for server tracing only - Core readers use original keys (works with browser and node-server) - Make __dd_ keys optional, set by node-server for dd-trace-js - Remove @deprecated markers since original keys are primary interface * docs: clarify flagMetadata key comments in node-server
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Make
DataDog/ffe-system-test-datathe canonical source for FFE/OpenFeature JSON fixtures in openfeature-js-client. This replaces copied package fixtures with the shared SDK corpus. Depends on DataDog/ffe-system-test-data#9.Changes
packages/node-server/test/ffe-system-test-dataas a git submodule pinned to the canonical fixture update.ufc-config.jsonand all sortedevaluation-cases/*.jsonfiles.gitsubmoduleupdates.Decisions
ffe-system-test-dataand is consumed through a submodule.Validation