[rust] unflag adaptive sampling override-env test#6948
Open
bm1549 wants to merge 2 commits into
Open
Conversation
Verified locally against dd-trace-rs main (release 0.3.3) using system-tests-local. TestDynamicConfigSamplingRules:: test_trace_sampling_rules_override_env now passes. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
bm1549
added
the
ai-generated
Contributor
|
|
bm1549
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0c68f8828e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Version-gate the now-passing test rather than doing a bare activation, since CI still runs against PROD_TAG=0.3.1 and the fix landed in 0.3.3. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
TestDynamicConfigSamplingRules::test_trace_sampling_rules_override_envwas marked asmissing_featurefor Rust, but it now passes against dd-trace-rsmain(release0.3.3). Verified locally withsystem-tests-local. The test passes after removing the marker.Changes
Remove the stale
missing_featureentry fortest_trace_sampling_rules_override_envfrommanifests/rust.yml.The other two entries in the same class (
test_trace_sampling_rules_override_rateandtest_trace_sampling_rules_with_tags) stay markedmissing_feature. Those have real tracer-side gaps and will be unflagged once the dd-trace-rs fixes land.Workflow
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? Onlymanifests/rust.ymlmodified.