Repository navigation
fix(auth-audit): accept 1Password vault and item ID references (DSE-2124) - #128
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Valid 1Password references such as
op://Private/<26-character item ID>/passwordcurrently failauth auditas committed credentials. DSE-2124 adds an exemption for exactly 26 lowercase ASCII alphanumerics in the vault/item positions of a three-partop://reference.The field and fragment retain their existing token checks. Other schemes, filesystem paths, malformed references and near-miss IDs receive no exemption. Validated vault/item IDs are masked only for the auth audit entropy pass; vendor patterns continue to scan the original value. The shared secret scanner is unchanged.
Both dependency locks also update only
opentelemetry-apifrom 1.45.1 to 1.45.2, using the two official PyPI release digests, to address GHSA-mf5v-w3w3-f6cg. Ernest approved this additional scoped remediation after the initial CI audit identified the unchanged vulnerable pins.Validation:
git diff --checkpassed.c04011f: GitHub Python 3.11 1,585 passed, 2 skipped; coverage 89.23%; deterministic seed-0 fuzz 55 passed. Run: https://github.com/DataScience-EngineeringExperts/mcp-warden/actions/runs/43583992154c04011f: independent chief-security-officer APPROVE via VP-engineering; independently repeated 106 focused tests and additional security cases.e80e2739e26b74dca037801660f566f350dc8d42: both hash sets verified against PyPI's 1.45.2 release. Clean builder hash-locked install andpip checkpass; 106 focused tests pass.Security-specific change: scoped implementation/PR and the additional two-lock OpenTelemetry remediation were separately approved by Ernest in the current authenticated chat. No release or credential changes. This PR does not close DSE-2124 until merged and verified.
Ticket: https://linear.app/dseofficial/issue/DSE-2124