Skip to content

fix(auth-audit): accept 1Password vault and item ID references (DSE-2124) - #128

Merged
ernestprovo23 merged 2 commits into
mainfrom
codex/dse2124-op-item-ids
Nov 14, 2026
Merged

ernestprovo23 merged 2 commits into
mainfrom
codex/dse2124-op-item-ids

Conversation

@ernestprovo23

@ernestprovo23 ernestprovo23 commented Nov 14, 2026 •

Copy link
Copy Markdown
Member

Valid 1Password references such as op://Private/<26-character item ID>/password currently fail auth audit as committed credentials. DSE-2124 adds an exemption for exactly 26 lowercase ASCII alphanumerics in the vault/item positions of a three-part op:// reference.

The field and fragment retain their existing token checks. Other schemes, filesystem paths, malformed references and near-miss IDs receive no exemption. Validated vault/item IDs are masked only for the auth audit entropy pass; vendor patterns continue to scan the original value. The shared secret scanner is unchanged.

Both dependency locks also update only opentelemetry-api from 1.45.1 to 1.45.2, using the two official PyPI release digests, to address GHSA-mf5v-w3w3-f6cg. Ernest approved this additional scoped remediation after the initial CI audit identified the unchanged vulnerable pins.

Validation:

Security-specific change: scoped implementation/PR and the additional two-lock OpenTelemetry remediation were separately approved by Ernest in the current authenticated chat. No release or credential changes. This PR does not close DSE-2124 until merged and verified.

Ticket: https://linear.app/dseofficial/issue/DSE-2124

@ernestprovo23
ernestprovo23 merged commit e003ddf into main Nov 14, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant