Skip to content

Feature: fix/db-leftovers to dev - #619

Merged
aamoghS merged 1 commit into
devfrom
fix/db-leftovers
Nov 14, 2026
Merged

aamoghS merged 1 commit into
devfrom
fix/db-leftovers

Conversation

@github-actions

@github-actions github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Automated PR tracking changes from fix/db-leftovers into dev.


Note

Medium Risk
New production constraint on initiative requires the data migration to run first; scope is narrow (commentary cites a single archived row with no applications).

Overview
Adds a database check constraint on initiative.max_members so only null (uncapped) or values > 0 are allowed, aligning the DB with existing API behavior that rejects zero capacity.

A one-time SQL migration sets max_members to null wherever it is ≤ 0, so production can apply the constraint without push failures; it must run before the schema deploy.

On club_project.tech, removes the Drizzle '{}'::text[] default so drizzle-kit stops repeatedly re-applying a mismatched default on every push; writers (e.g. seed) already supply the array.

Reviewed by Cursor Bugbot for commit 6e92f95. Bugbot is set up for automated code reviews on this repo. Configure here.

club_project.tech loses its array default. drizzle-kit read it back in a
different spelling and re-applied it on every push; the seed, the only
writer, always sets it. With that and the earlier primary key fix, a push
against an up-to-date database now reports no changes.

Adds initiative_max_members_check (null or > 0), which the API already
enforces. packages/db/sql/2026-11-initiative-max-members.sql clears the one
production row at 0, an archived initiative with no applications, and runs
before this deploys.
@github-actions

Copy link
Copy Markdown
Contributor Author

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@github-actions github-actions Bot added the bug Something isn't working label Nov 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor Author

Visit the preview URL for this PR (updated for commit 6e92f95):

https://hacklyticss2026--pr-619-8nih2ecd.web.app

(expires Sat, 21 Nov 2026 23:42:10 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 5d238be33273095766c18a8339b7b0c47de8a950

@github-actions

Copy link
Copy Markdown
Contributor Author

Visit the preview URL for this PR (updated for commit 6e92f95):

https://hacklytics2027--pr-619-xls2j92z.web.app

(expires Sat, 21 Nov 2026 23:42:13 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c48ba34db61581e25fe2978355160b5eefe0e83f

@aamoghS
aamoghS merged commit c1584d2 into dev Nov 14, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⤵️ pull bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant