Repository navigation
Feature: fix/db-leftovers to dev - #619
Merged
Merged
Conversation
club_project.tech loses its array default. drizzle-kit read it back in a different spelling and re-applied it on every push; the seed, the only writer, always sets it. With that and the earlier primary key fix, a push against an up-to-date database now reports no changes. Adds initiative_max_members_check (null or > 0), which the API already enforces. packages/db/sql/2026-11-initiative-max-members.sql clears the one production row at 0, an archived initiative with no applications, and runs before this deploys.
Contributor
Author
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
Author
|
Visit the preview URL for this PR (updated for commit 6e92f95): https://hacklyticss2026--pr-619-8nih2ecd.web.app (expires Sat, 21 Nov 2026 23:42:10 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 5d238be33273095766c18a8339b7b0c47de8a950 |
Contributor
Author
|
Visit the preview URL for this PR (updated for commit 6e92f95): https://hacklytics2027--pr-619-xls2j92z.web.app (expires Sat, 21 Nov 2026 23:42:13 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c48ba34db61581e25fe2978355160b5eefe0e83f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated PR tracking changes from
fix/db-leftoversintodev.Note
Medium Risk
New production constraint on
initiativerequires the data migration to run first; scope is narrow (commentary cites a single archived row with no applications).Overview
Adds a database check constraint on
initiative.max_membersso only null (uncapped) or values > 0 are allowed, aligning the DB with existing API behavior that rejects zero capacity.A one-time SQL migration sets
max_membersto null wherever it is ≤ 0, so production can apply the constraint without push failures; it must run before the schema deploy.On
club_project.tech, removes the Drizzle'{}'::text[]default sodrizzle-kitstops repeatedly re-applying a mismatched default on every push; writers (e.g. seed) already supply the array.Reviewed by Cursor Bugbot for commit 6e92f95. Bugbot is set up for automated code reviews on this repo. Configure here.