Repository navigation
Conversation
club_project.tech loses its array default. drizzle-kit read it back in a different spelling and re-applied it on every push; the seed, the only writer, always sets it. With that and the earlier primary key fix, a push against an up-to-date database now reports no changes. Adds initiative_max_members_check (null or > 0), which the API already enforces. packages/db/sql/2026-11-initiative-max-members.sql clears the one production row at 0, an archived initiative with no applications, and runs before this deploys.
Feature: fix/db-leftovers to dev
Contributor
Author
Contributor
Author
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
Author
|
Visit the preview URL for this PR (updated for commit c1584d2): https://hacklyticss2026--pr-620-5wcr8rfy.web.app (expires Sat, 21 Nov 2026 23:46:27 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 5d238be33273095766c18a8339b7b0c47de8a950 |
Contributor
Author
|
Visit the preview URL for this PR (updated for commit c1584d2): https://hacklytics2027--pr-620-2t4e64hv.web.app (expires Sat, 21 Nov 2026 23:46:32 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c48ba34db61581e25fe2978355160b5eefe0e83f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated PR tracking changes from
devintomain.Note
Medium Risk
Deploy ordering matters: production must run the data fix before the new check constraint, and the constraint changes what values the database accepts for initiative capacity.
Overview
Adds a PostgreSQL check on
initiative.max_membersso any set value must be greater than zero, aligning the database with existing API behavior wherenullmeans uncapped and zero is invalid.Ships a one-time migration (
2026-11-initiative-max-members.sql) that setsmax_memberstonullwherever it is≤ 0, which must be applied in production before this schema deploys or adding the check will fail.On
club_project, removes the Drizzle default on thetechtext array sodrizzle-kitstops rewriting the column on every push; writers (seed) already supply the field explicitly.Reviewed by Cursor Bugbot for commit c1584d2. Bugbot is set up for automated code reviews on this repo. Configure here.