Repository navigation
Feature: fix/judging-checklist-empty to dev - #625
Merged
Merged
Conversation
The launch checklist counted two steps as done on an empty edition: rooms, because no scheduled challenge had projects, and claims, because no project came from Devpost. Both are only true because there are no projects, so a new edition read 2 of 7 ready with nothing set up. They now wait for projects, and say so, and behave as before once any exist. The test that pinned the old behaviour, named for nothing being done on a new edition, now asserts that.
Contributor
Author
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
Author
|
Visit the preview URL for this PR (updated for commit db890cb): https://hacklyticss2026--pr-625-881z94d2.web.app (expires Sun, 22 Nov 2026 01:32:35 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 5d238be33273095766c18a8339b7b0c47de8a950 |
Contributor
Author
|
Visit the preview URL for this PR (updated for commit db890cb): https://hacklytics2027--pr-625-1ii4lj5f.web.app (expires Sun, 22 Nov 2026 01:32:38 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c48ba34db61581e25fe2978355160b5eefe0e83f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated PR tracking changes from
fix/judging-checklist-emptyintodev.Note
Low Risk
Small checklist logic change with matching unit tests; affects admin UX messaging, not judging execution or data writes.
Overview
Fixes the judging launch checklist so a brand-new edition with no imported projects no longer looks partly complete.
Rooms and claims used to mark
done: truewhen there were zero projects (e.g. “nothing needs a room” or “no Devpost to claim”). They now stay incomplete and show a shared “Waits for projects” hint untildevpost + portalentries exist. Claims only auto-complete as “all portal” when there is at least one project anddevpost === 0.Tests in
checklist.test.tswere updated for the empty-edition case and for portal-only projects with no schedule yet.graphify-out/GRAPH_REPORT.mdwas regenerated at commited59738a(graph metadata only).Reviewed by Cursor Bugbot for commit db890cb. Bugbot is set up for automated code reviews on this repo. Configure here.