Skip to content

Feature: fix/judging-checklist-empty to dev - #625

Merged
aamoghS merged 1 commit into
devfrom
fix/judging-checklist-empty
Nov 15, 2026
Merged

aamoghS merged 1 commit into
devfrom
fix/judging-checklist-empty

Conversation

@github-actions

@github-actions github-actions Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Automated PR tracking changes from fix/judging-checklist-empty into dev.


Note

Low Risk
Small checklist logic change with matching unit tests; affects admin UX messaging, not judging execution or data writes.

Overview
Fixes the judging launch checklist so a brand-new edition with no imported projects no longer looks partly complete.

Rooms and claims used to mark done: true when there were zero projects (e.g. “nothing needs a room” or “no Devpost to claim”). They now stay incomplete and show a shared “Waits for projects” hint until devpost + portal entries exist. Claims only auto-complete as “all portal” when there is at least one project and devpost === 0.

Tests in checklist.test.ts were updated for the empty-edition case and for portal-only projects with no schedule yet. graphify-out/GRAPH_REPORT.md was regenerated at commit ed59738a (graph metadata only).

Reviewed by Cursor Bugbot for commit db890cb. Bugbot is set up for automated code reviews on this repo. Configure here.

The launch checklist counted two steps as done on an empty edition: rooms,
because no scheduled challenge had projects, and claims, because no project
came from Devpost. Both are only true because there are no projects, so a new
edition read 2 of 7 ready with nothing set up. They now wait for projects,
and say so, and behave as before once any exist.

The test that pinned the old behaviour, named for nothing being done on a
new edition, now asserts that.
@github-actions

Copy link
Copy Markdown
Contributor Author

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@github-actions github-actions Bot added the bug Something isn't working label Nov 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor Author

Visit the preview URL for this PR (updated for commit db890cb):

https://hacklyticss2026--pr-625-881z94d2.web.app

(expires Sun, 22 Nov 2026 01:32:35 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 5d238be33273095766c18a8339b7b0c47de8a950

@github-actions

Copy link
Copy Markdown
Contributor Author

Visit the preview URL for this PR (updated for commit db890cb):

https://hacklytics2027--pr-625-1ii4lj5f.web.app

(expires Sun, 22 Nov 2026 01:32:38 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c48ba34db61581e25fe2978355160b5eefe0e83f

@aamoghS
aamoghS merged commit 35ba5bb into dev Nov 15, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⤵️ pull bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant