Port HTML templates to Jinja2#60
Merged
DavidBuchanan314 merged 2 commits intomainfrom Oct 5, 2025
Merged
Conversation
Owner
DavidBuchanan314
commented
Oct 5, 2025
DavidBuchanan314
commented
- Add jinja2 dependency for secure HTML templating
- Move templates from inline strings to separate HTML files
- Use FileSystemLoader to load templates at startup (auto_reload=False)
- Enable auto-escaping for XSS protection
- Implement template inheritance with base.html
- Add jinja2 dependency for secure HTML templating - Move templates from inline strings to separate HTML files - Use FileSystemLoader to load templates at startup (auto_reload=False) - Enable auto-escaping for XSS protection - Implement template inheritance with base.html
- Remove html_templates.py wrapper module - Set up Jinja2 environment in construct_app() in service.py - Add MILLIPDS_JINJA_ENV AppKey and get_jinja_env() helper - Update auth_oauth.py to render templates directly at point of use - Fix deprecation warning: raise HTTPNotFound instead of returning it
Owner
Author
|
thought about adding bytecode caching but almost certainly not worth it for this use case |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.