Skip to content

Finish non-code design audit remediation - #58

Merged
DavidHLP merged 9 commits into
mainfrom
codex/non-code-design-remediation
Oct 9, 2026
Merged

DavidHLP merged 9 commits into
mainfrom
codex/non-code-design-remediation

Conversation

@DavidHLP

@DavidHLP DavidHLP commented Oct 9, 2026 •

Copy link
Copy Markdown
Owner

The packaged-consumer command still required JAVA_HOME, documentation checks had two owners and hardcoded versions, and migration guidance lacked a runnable operator procedure. Finish the remaining non-code audit remediation on top of main's existing candidate verification and Central publication pipeline.

Implementation includes portable JDK selection and fail-closed candidate handling, a single canonical docs guard, and safe migration/contributor guidance. Shared verification, strict ci-ok, candidate reuse, release signing/Portal completion, optional advisory scans, no-Docker tests and real Redis checks are retained from PR #42.

Validated commit 6df25107342741095daa6e079aad94595f7cab1d in an isolated remote-dev checkout with JDK 21:

  • Unit: 785 tests; full Redis suite: 992 tests. Zero failures, errors or skips; coverage 93.19% line / 81.95% branch.
  • Docs, naming, workflow guards, 23 Python regressions, Checkstyle, candidate verification and all three packaged-consumer profiles passed.
  • Benchmark package and bounded JMH smoke passed. The documented CLI procedure decoded one legacy value against temporary Redis in dry-run, with no writes or source changes.
  • All 11 GitHub checks passed, including the fresh ready-for-review run: https://github.com/DavidHLP/ResiCache/actions/runs/37901639809
  • Independent Standards and Spec reviewers reported zero required findings on the final commit.

No production publication or migration-runtime behavior change is included. Publication tests use temporary GPG keys and a local HTTP Portal fixture; actual Central publication was not run. The separate documentation PR #53 and remote dirty workspace are preserved.

Closes #54
Closes #55
Closes #56
Closes #57

@DavidHLP
DavidHLP marked this pull request as ready for review October 9, 2026 07:53
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-09T07:56:39.184989Z 6df2510 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@DavidHLP
DavidHLP merged commit edd5764 into main Oct 9, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant