Multi-target for .NET Framework 4.8 + .NET 8, 9 and 10#7
Open
luttje wants to merge 2 commits intoDavidRieman:mainfrom
Open
Multi-target for .NET Framework 4.8 + .NET 8, 9 and 10#7luttje wants to merge 2 commits intoDavidRieman:mainfrom
luttje wants to merge 2 commits intoDavidRieman:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi again, hope you're well.
For our project we're looking to update to .NET 9 (and beyond). Since we rely on SimWinGamePad, it would be super helpful if that supported .NET 8, 9 and 10.
This PR updates to the new SDK-style
.csprojformat and adds multi-targeting across the three library projects (SimWinKeyboard, SimWinMouse, SimWinGamePad), so a single NuGet package covers all of:net48: existing .NET Framework users are unaffected (I tested this)net8.0-windows: .NET 8 LTS [source]net9.0-windows: .NET 9 STS (I tested this)net10.0-windows: .NET 10 LTSThe SimExamples WPF app targets
net9.0-windowsas a single-target executable. (I tested this)What changed:
.csprojfiles converted from legacy MSBuild format to modern SDK-style (much shorter and easier to maintain)System,System.Windows.Forms, etc.) removed. These are automatically included by the SDK.UseWindowsForms=trueset on Mouse and GamePad (which useMouseButtons,MessageBox, etc.)UseWPF=trueset on SimExamples.csfiles. Everything still compiles cleanly across all four targetsAll projects build with
Build succeeded(the only output is a handful ofCA1416platform-guard warnings on Windows-only APIs, which is expected and fine for this Windows-only input simulation library).Let me know if I need to adjust anything.
Thanks for maintaining this library!