Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion dojo/tools/govulncheck/parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,22 @@ def get_location(data, node):
def get_version(data, node):
return data["Requires"]["Modules"][str(node)]["Version"]

@staticmethod
def get_fix_info(affected_ranges):
for r in affected_ranges:
for event in r.get("events", []):
if "fixed" in event:
return True, event["fixed"]
return False, ""

@staticmethod
def get_introduced_version(affected_ranges):
for r in affected_ranges:
for event in r.get("events", []):
if "introduced" in event:
return event["introduced"]
return ""

def get_finding_trace_info(self, data, osv_id):
# Browse the findings to look for matching OSV-id. If the OSV-id is matching, extract traces.
trace_info_strs = []
Expand Down Expand Up @@ -202,8 +218,12 @@ def get_findings(self, scan_file, test):
else:
title = f"{osv_data['id']} - {affected_package['name']}"

affected_version = self.get_affected_version(data, osv_data["id"])
fix_available, fix_version = self.get_fix_info(affected_ranges)

affected_version = (
self.get_affected_version(data, osv_data["id"])
or self.get_introduced_version(affected_ranges)
)
severity = elem["osv"].get("severity", SEVERITY)

d = {
Expand All @@ -215,6 +235,8 @@ def get_findings(self, scan_file, test):
"description": description,
"impact": impact,
"references": references,
"fix_available": fix_available,
"fix_version": fix_version,
"file_path": path,
"url": db_specific_url,
"unique_id_from_tool": osv_id,
Expand Down
2 changes: 2 additions & 0 deletions unittests/tools/test_govulncheck_parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,8 @@ def test_parse_new_version_many_findings_custom_severity(self):
self.assertIsNotNone(finding.impact)
self.assertIsNotNone(finding.description)
self.assertIsNotNone(finding.references)
self.assertTrue(finding.fix_available)
self.assertEqual("0.3.8", finding.fix_version)

def test_parse_issue_14642(self):
with (get_unit_tests_scans_path("govulncheck") / "issue_14642.json").open(encoding="utf-8") as testfile:
Expand Down
Loading