Skip to content

Fix selection persistence in block forms #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Denis-RZ merged 1 commit into from
Jun 23, 2025
Merged

Fix selection persistence in block forms #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions website/MyWebApp/Views/AdminBlockTemplate/AddToPage.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@
<div>
<label>Assign To Pages</label>
<select id="page-select" name="pageIds" multiple size="5">
<option value="0" selected="@(selectedPages.Contains(0))">All Pages</option>
<option value="0" selected="@(selectedPages.Contains(0) ? "selected" : null)">All Pages</option>
@foreach (var p in ViewBag.Pages as List<Page>)
{
<option value="@p.Id" selected="@(selectedPages.Contains(p.Id))">@p.Slug</option>
<option value="@p.Id" selected="@(selectedPages.Contains(p.Id) ? "selected" : null)">@p.Slug</option>
}
</select>
</div>
Expand All @@ -30,18 +30,18 @@
<select id="zone-select" name="zone">
@foreach (var z in ViewBag.Zones as List<string>)
{
<option value="@z" selected="@(selectedZone == z)">@z</option>
<option value="@z" selected="@(selectedZone == z ? "selected" : null)">@z</option>
}
</select>
</div>
<div>
<label>Role</label>

<select name="role">
<option value="" selected="@(string.IsNullOrEmpty(selectedRole))">(none)</option>
<option value="" selected="@(string.IsNullOrEmpty(selectedRole) ? "selected" : null)">(none)</option>
@foreach (var r in ViewBag.Roles as List<Role>)
{
<option value="@r.Name" selected="@(selectedRole == r.Name)">@r.Name</option>
<option value="@r.Name" selected="@(selectedRole == r.Name ? "selected" : null)">@r.Name</option>
}

</select>
Expand Down
10 changes: 5 additions & 5 deletions website/MyWebApp/Views/AdminBlockTemplate/_PageAssignment.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@
<label>Pages</label>
<input type="text" id="page-display" readonly />
<select id="page-select" name="pageIds" multiple size="5">
<option value="0" selected="@(selectedPages.Contains(0))">All Pages</option>
<option value="0" selected="@(selectedPages.Contains(0) ? "selected" : null)">All Pages</option>
@foreach (var p in ViewBag.Pages as List<Page>)

Check warning on line 14 in website/MyWebApp/Views/AdminBlockTemplate/_PageAssignment.cshtml

View workflow job for this annotation

GitHub Actions / build 

Dereference of a possibly null reference.

Check warning on line 14 in website/MyWebApp/Views/AdminBlockTemplate/_PageAssignment.cshtml

View workflow job for this annotation

GitHub Actions / build 

Dereference of a possibly null reference.
{
<option value="@p.Id" selected="@(selectedPages.Contains(p.Id))">@p.Slug</option>
<option value="@p.Id" selected="@(selectedPages.Contains(p.Id) ? "selected" : null)">@p.Slug</option>
}
</select>
</div>
Expand All @@ -22,17 +22,17 @@
<select id="zone-select" name="zone">
@foreach (var z in ViewBag.Zones as List<string>)
{
<option value="@z" selected="@(selectedZone == z)">@z</option>
<option value="@z" selected="@(selectedZone == z ? "selected" : null)">@z</option>
}
</select>
</div>
<div>
<label>Role</label>
<select name="role">
<option value="" selected="@(string.IsNullOrEmpty(selectedRole))">(none)</option>
<option value="" selected="@(string.IsNullOrEmpty(selectedRole) ? "selected" : null)">(none)</option>
@foreach (var r in ViewBag.Roles as List<Role>)
{
<option value="@r.Name" selected="@(selectedRole == r.Name)">@r.Name</option>
<option value="@r.Name" selected="@(selectedRole == r.Name ? "selected" : null)">@r.Name</option>
}
</select>
</div>
Expand Down
Loading