Repository navigation
chore(deps): bump node-forge to 1.4.2 - #587
Merged
Merged
Conversation
node-forge 1.4.2 throws on a PKCS#1 v1.5 signature with garbage in its DigestInfo, where 1.4.0 accepted it (GHSA-86w9-cpqp-85rv). One TcpUsb test used forge's verify() to show that its forged signature fools a lax verifier, so it failed on 1.4.2 (Dependabot's #578). adbkit itself checks AUTH signatures with OpenSSL, not node-forge, so nothing outside the test changes. The test now checks the signature with OpenSSL instead: the padding is valid and ends in the token, and only the DigestInfo has garbage in it. Raise the range to ^1.4.2 so consumers get the fixed node-forge too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Karol Wrótniak <karol.wrotniak@droidsonroids.pl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #578 (Dependabot's node-forge 1.4.0 → 1.4.2), which fails CI.
node-forge 1.4.2 throws on a PKCS#1 v1.5 signature with garbage in its DigestInfo (GHSA-86w9-cpqp-85rv). Version 1.4.0 accepted it. The TcpUsb test "should not accept garbage in the DigestInfo from a known key" called forge's
verify()to check that its forged signature would fool a lax verifier. On 1.4.2 that call throws, so the test failed.adbkit's code doesn't change. The TcpUsb bridge checks AUTH signatures with OpenSSL in
verifies()(since #570), not with node-forge. node-forge is still used to parse keys and for theadbkitCLI.Changes
node-forgeis locked at 1.4.2, the version Dependabot proposed, and the range goes from^1.4.0to^1.4.2so consumers get the fixed version as well. 1.4.3 came out 3 days ago, so I left it for Dependabot.crypto.publicDecryptwith PKCS#1 padding): the padding is valid and ends in the token, and only the DigestInfo has garbage in it. This doesn't depend on the node-forge version.Testing
verifies()so it only compares the trailing token. Both garbage-DigestInfo tests then fail; with the realverifies()they pass.🤖 Generated with Claude Code