Repository navigation
Force patched minimatch and glob in dev dependencies - #588
Merged
Merged
Conversation
minimatch 10.x (GHSA-g3hv-75wg-m249) and glob 9-14.0.1 (GHSA-3g3m-2fjr-6pw4) have no fix inside the ranges eslint, typescript-eslint and mocha ask for. Override them to minimatch 11 and glob 14, which upstream releases together. Both are dev-only, so the published package does not change. Drop the overrides once eslint, typescript-eslint and mocha depend on minimatch 11 and glob 14 themselves. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Karol Wrótniak <karol.wrotniak@droidsonroids.pl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the open Dependabot alert for minimatch (GHSA-g3hv-75wg-m249). It also covers glob (GHSA-3g3m-2fjr-6pw4), which
npm auditreports and Dependabot hasn't raised here yet.Neither has a fix inside the ranges eslint, typescript-eslint and mocha ask for (minimatch
^10, glob^13). This adds npmoverridesthat pin minimatch 11 and glob 14; upstream releases those two together, and glob 14 itself depends on minimatch^11.0.5. Both are dev-only, so the published package doesn't change and users were never affected.Remove the overrides once eslint, typescript-eslint and mocha depend on minimatch 11 and glob 14 themselves.
Checked
Ran
npm ci, lint, compile and test from a cleannode_modules, in CI's order, on master and on this branch. The results are identical: 327 passing, 13 pending; ESLint checks 150 files.npm auditnow reports 0 vulnerabilities.minimatch 11 needs Node 20 or later; CI and
enginesalready require 22.🤖 Generated with Claude Code