Fix ImGui shutdown and update EX31 runtime fixes#1037
Open
AnastaZIuk wants to merge 7 commits intopath_tracer_beautyfrom
Open
Fix ImGui shutdown and update EX31 runtime fixes#1037AnastaZIuk wants to merge 7 commits intopath_tracer_beautyfrom
AnastaZIuk wants to merge 7 commits intopath_tracer_beautyfrom
Conversation
…_assert_2026_04_01 Update DXC for EX40 lexed inline method assert fix
Member
Author
|
Devsh-Graphics-Programming/Nabla-Examples-and-Tests#264 (comment) ex40 assert issue microsoft/DirectXShaderCompiler#8324 is gone now, CI green and ready for deployment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nbl::ext::imgui::UIteardown so shutdown only ends an active frame on the owned ImGui contextexamples_teststo the paired EX31 fixes from Devsh-Graphics-Programming/Nabla-Examples-and-Tests#264, including the RWMC default reset used for brightness-parity comparisonsRoot cause
The engine-side runtime break here is separate from the EX31 routing fixes in
examples_tests.UI::~UI()was introduced in2de19f25cfwhen the ImGui backend grew explicit shared-atlas ownership handling. In that shape the destructor unconditionally calledImGui::EndFrame()whenever the UI instance owned the atlas, without checking whether the owned context was current or whether a frame was still open.699e841a38later widened the practical exposure on the packaged-SPIR-V path by letting the UI consume precompiled ImGui shaders, which is the route exercised by this branch.On the EX31 screenshot and exit path teardown can happen after the frame has already been ended, so the destructor hits ImGui's debug break even though rendering already finished correctly. The EX31 warmup, rectangle, and RWMC regressions themselves live in
examples_tests, so the right Nabla-side fix is just the shutdown guard together with the paired submodule update. The additional RWMC-defaults tuning in that submodule update is an examples-side comparison-quality upgrade, not an engine-side regression fix.