Open
Conversation
include/nbl/builtin/hlsl/concepts/accessors/hierarchical_image.hlsl
Outdated
Show resolved
Hide resolved
include/nbl/ext/EnvmapImportanceSampling/builtin/hlsl/common.hlsl
Outdated
Show resolved
Hide resolved
include/nbl/ext/EnvmapImportanceSampling/builtin/hlsl/common.hlsl
Outdated
Show resolved
Hide resolved
include/nbl/ext/EnvmapImportanceSampling/builtin/hlsl/common.hlsl
Outdated
Show resolved
Hide resolved
include/nbl/ext/EnvmapImportanceSampling/builtin/hlsl/measure_luma.comp.hlsl
Outdated
Show resolved
Hide resolved
Member
|
@kevyuu you've somehow reverted the submodule pointers |
include/nbl/builtin/hlsl/sampling/hierarchical_image/accessors.hlsl
Outdated
Show resolved
Hide resolved
include/nbl/builtin/hlsl/sampling/hierarchical_image/common.hlsl
Outdated
Show resolved
Hide resolved
include/nbl/builtin/hlsl/sampling/hierarchical_image/gen_luma.comp.hlsl
Outdated
Show resolved
Hide resolved
The `generate` function in `HierarchicalWarpGenerator` was updated: - Replaced `xi` parameter with `v` and introduced a local `xi`. - Adjusted `directionUV` calculation to normalize coordinates by subtracting `0.5` and dividing by `_lastTexel` for improved accuracy. - Added a comment to clarify the normalization process. Commit by Kevin Yudi Utama
Commit by Kevin Yudi Utama
Refine concepts and simplify calculations in hierarchical image sampling.
kevyuu
force-pushed
the
env_map_importance_sampling
branch
from
a72eb28 to
769f5f4
Compare
- Remove `ScalarT` template parameter and derive `scalar_type` from `LuminanceAccessorT`. - Remove `_layerIndex` from `HierarchicalWarpGenerator` and encapsulate layer handling in `LuminanceAccessorT`. - Use `getAvgLuma` from `LuminanceAccessorT` instead of external `rcpAvgLuma`. - Introduce `MipmappedLuminanceReadAccessor` concept to define accessor requirements. - Refactor `LuminanceAccessor` to encapsulate layer index and provide methods like `get`, `resolution`, and `getAvgLuma`. - Update `gen_warp.comp.hlsl` to use the refactored `LuminanceAccessor` and `HierarchicalWarpGenerator` interfaces.
No longer extension, so no need to mount.
The purpose of SSession is so that we don't need to recreate new pipeline from scratch for each envmap.;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rework environment map importance sampling to vulkan and hlsl
Testing
Rework example 0 to use vulkan and hlsl
Unit Test Pull Request
TODO list: