Skip to content

LIMS-2174: Add ability to add elements to proteins#1072

Merged
ndg63276 merged 1 commit into
pre-release/2026-R3.1from
improvement/LIMS-2174/add-elements-to-proteins
Jun 2, 2026
Merged

LIMS-2174: Add ability to add elements to proteins#1072
ndg63276 merged 1 commit into
pre-release/2026-R3.1from
improvement/LIMS-2174/add-elements-to-proteins

Conversation

@ndg63276
Copy link
Copy Markdown
Collaborator

JIRA ticket: LIMS-2174

Summary:

Now that we have a Protein_has_Component table (DiamondLightSource/ispyb-database#318), and each element is a component, we would like a way for each protein to be associated with some elements via Synchweb. Needs to be quick to type in, not just select from a 118 element dropdown.

Changes:

  • Add access to Component and Protein_has_Component tables
  • Add endpoints for getting a list of elements (either all, or those attached to a protein), adding an element to a protein, and removing an element from a protein
  • Add a new Backbone collection for elements, and modified CSS to display it
  • Add a textbox to add new elements to a protein, with an add button (or use the enter key)
  • Stop the (similar) add PDB box from scrolling to the top of the page

To test:

  • Go to any proposal, then go to proteins, then go to any protein, eg /proteins/pid/635322
  • Add and delete elements from the protein (using 1 or 2 letter codes eg H, C, Se), check they appear correctly and persevere after a refresh
  • Check a sensible message appears when there are no associated elements

@ndg63276 ndg63276 changed the base branch from master to pre-release/2026-R3.1 June 2, 2026 09:56
@ndg63276 ndg63276 merged commit 50008de into pre-release/2026-R3.1 Jun 2, 2026
2 checks passed
@ndg63276 ndg63276 deleted the improvement/LIMS-2174/add-elements-to-proteins branch June 2, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants