Add i15-1 crystal lut#183
Merged
Merged
Conversation
4 tasks
DominicOram
requested changes
May 26, 2026
Collaborator
DominicOram
left a comment
DominicOram
left a comment
There was a problem hiding this comment.
Thanks, just the one comment for things we can do in the future
| XPDF_CRYSTAL_COLUMN_NAMES = Literal["y_mm", "energy_keV"] | ||
|
|
||
|
|
||
| class XpdfCrystalLookupTable(LookupTableBase[XPDF_CRYSTAL_COLUMN_NAMES]): |
Collaborator
There was a problem hiding this comment.
Should: Could we have a comment in here that, unlike other parameters in the config server, we don't actually need these in GDA. Then make an issue to look at moving this into something like redis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for DiamondLightSource/crystallography-bluesky#47
I've also added a config file at
/dls_sw/i15-1/software/daq_configuration/xpdf_crystal_lut.txtto be read by the config server