Skip to content

Update to PyQt6 and fix ci#34

Merged
M-Chan merged 23 commits into
new-mainfrom
ci-fixing
Jun 4, 2026
Merged

Update to PyQt6 and fix ci#34
M-Chan merged 23 commits into
new-mainfrom
ci-fixing

Conversation

@M-Chan
Copy link
Copy Markdown

@M-Chan M-Chan commented May 27, 2026

No description provided.

@M-Chan M-Chan requested a review from JamesOHeaDLS May 27, 2026 08:30
@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

❌ Patch coverage is 87.37475% with 189 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.49%. Comparing base (1d405a7) to head (62dd1d7).

Files with missing lines Patch % Lines
src/dls_pmac_control/__main__.py 55.95% 85 Missing ⚠️
src/dls_pmac_control/axissettings.py 81.63% 36 Missing ⚠️
src/dls_pmac_control/gather.py 83.19% 20 Missing ⚠️
src/dls_pmac_control/comms_thread.py 68.88% 14 Missing ⚠️
src/dls_pmac_control/ppmacgather.py 87.20% 11 Missing ⚠️
src/dls_pmac_control/watches.py 82.25% 11 Missing ⚠️
src/dls_pmac_control/gatherchannel.py 85.71% 7 Missing ⚠️
src/dls_pmac_control/energise.py 90.47% 4 Missing ⚠️
src/dls_pmac_control/status.py 96.87% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           new-main      #34      +/-   ##
============================================
+ Coverage     88.47%   88.49%   +0.02%     
============================================
  Files            24       24              
  Lines          4990     4990              
============================================
+ Hits           4415     4416       +1     
+ Misses          575      574       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@JamesOHeaDLS JamesOHeaDLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks TingTing. Well done for addressing so many of those linting issues. There are a few needed in main.py, I'm not sure why the tools don't pick them up.

Comment thread src/dls_pmac_control/ui_form_axis_settings.py
Comment thread src/dls_pmac_control/__main__.py Outdated
Comment thread src/dls_pmac_control/__main__.py Outdated
Comment thread src/dls_pmac_control/__main__.py Outdated
Comment thread src/dls_pmac_control/__main__.py Outdated
@M-Chan M-Chan requested a review from JamesOHeaDLS June 3, 2026 15:46
Copy link
Copy Markdown
Contributor

@JamesOHeaDLS JamesOHeaDLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks TingTing, looks good. Ready to merge as a squash merge

@M-Chan M-Chan merged commit 915be0e into new-main Jun 4, 2026
18 of 19 checks passed
@M-Chan M-Chan deleted the ci-fixing branch June 4, 2026 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants