set alert_end_time for each visit separately#809
Merged
Conversation
and remove this from db when session removed
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #809 +/- ##
==========================================
- Coverage 52.08% 50.67% -1.41%
==========================================
Files 96 96
Lines 10414 11070 +656
Branches 1381 1568 +187
==========================================
+ Hits 5424 5610 +186
- Misses 4706 5155 +449
- Partials 284 305 +21 🚀 New features to boost your workflow:
|
remove prometheus metric and remove endpoint to switch on/off
stephen-riggs
approved these changes
May 28, 2026
Contributor
stephen-riggs
left a comment
There was a problem hiding this comment.
Thanks, this looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-> therefore don't need to check if new alert_end_time is longer than existing time (when creating or updating visit end time)