Skip to content

set alert_end_time for each visit separately#809

Merged
Abigail-Yates merged 2 commits into
mainfrom
alert-end-time-visits
May 28, 2026
Merged

set alert_end_time for each visit separately#809
Abigail-Yates merged 2 commits into
mainfrom
alert-end-time-visits

Conversation

@Abigail-Yates
Copy link
Copy Markdown
Collaborator

  • added "visit" label to alert_end_time so each visit now has a different alert_end_time
    -> therefore don't need to check if new alert_end_time is longer than existing time (when creating or updating visit end time)
  • remove alert_end_time for that visit when session removed

and remove this from db when session removed
@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.67%. Comparing base (d62487f) to head (1709dc6).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #809      +/-   ##
==========================================
- Coverage   52.08%   50.67%   -1.41%     
==========================================
  Files          96       96              
  Lines       10414    11070     +656     
  Branches     1381     1568     +187     
==========================================
+ Hits         5424     5610     +186     
- Misses       4706     5155     +449     
- Partials      284      305      +21     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

remove prometheus metric and remove endpoint to switch on/off
Copy link
Copy Markdown
Contributor

@stephen-riggs stephen-riggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me

@Abigail-Yates Abigail-Yates merged commit 62f45b7 into main May 28, 2026
17 checks passed
@Abigail-Yates Abigail-Yates deleted the alert-end-time-visits branch May 28, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants