Skip to content

ENG-1608: Add command to create Base view for a node type#935

Open
trangdoan982 wants to merge 4 commits intomainfrom
eng-1608-create-command-to-create-a-base-for-a-node-type
Open

ENG-1608: Add command to create Base view for a node type#935
trangdoan982 wants to merge 4 commits intomainfrom
eng-1608-create-command-to-create-a-base-for-a-node-type

Conversation

@trangdoan982
Copy link
Copy Markdown
Member

@trangdoan982 trangdoan982 commented Apr 2, 2026

https://www.loom.com/share/32a36f135ea74cbaaaf06de57ad54da3

Summary

  • Adds a "Create Base view for node type" command that generates a .base YAML file filtered by nodeTypeId, making it easy to create table views for any node type without needing to know the cryptic auto-generated ID
  • Three entry points: command palette, node type settings page, and discourse context panel
  • Always creates a new .base file (with incrementing suffix if name exists) to avoid routing users to a modified Base view with stale filters

Test plan

  • Command palette: Open command palette → "Create Base view for node type" → select a node type → verify .base file is created with correct nodeTypeId filter and opens
  • Duplicate handling: Run the command again for the same node type → verify it creates a new file with suffix (e.g., "Claim Nodes 1.base")
  • Settings: Go to Settings → Node Types → click a node type → click "Create Base view" → verify same behavior
  • Settings guard: Add a new unsaved node type → verify "Create Base view" button is not shown
  • Context panel: Open a discourse node → in the Discourse Context panel, click the layout-list icon next to the node type badge → verify same behavior
  • Existing node type menu: Open command palette → "Open node type menu" with text selected → verify the node type picker still works for creating discourse nodes
  • Base view works: In the opened .base file, verify Obsidian shows a table with only nodes of that type

🤖 Generated with Claude Code


Open with Devin

@linear
Copy link
Copy Markdown

linear bot commented Apr 2, 2026

@supabase
Copy link
Copy Markdown

supabase bot commented Apr 2, 2026

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

devin-ai-integration[bot]

This comment was marked as resolved.

Adds a "Create Base view for node type" command that generates a .base
YAML file filtered by nodeTypeId, with entry points from the command
palette, node type settings, and discourse context panel.

Also refactors NodeTypeModal to accept a generic callback instead of
being hardcoded to createDiscourseNode, enabling reuse across both
the existing node creation flow and the new Base view creation.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@trangdoan982 trangdoan982 force-pushed the eng-1608-create-command-to-create-a-base-for-a-node-type branch from 89a0933 to 9ad2b0d Compare April 2, 2026 17:53
trangdoan982 and others added 2 commits April 2, 2026 11:10
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
devin-ai-integration[bot]

This comment was marked as resolved.

@trangdoan982 trangdoan982 requested a review from mdroidian April 2, 2026 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant