ENG-1514: Separate tentative (imported) relations from current in RelationshipSection#941
Open
trangdoan982 wants to merge 1 commit intomainfrom
Open
Conversation
…ationshipSection - Rename `provisional` → `tentative` on RelationInstance for consistent terminology - Add `updateRelation()` to relationsStore for patching relation fields - Split RelationshipSection into "Current Relationships" (tentative !== false) and "Tentative Relationships" (tentative === false) sections - Tentative section has a native Obsidian toggle to show/hide, a ✓ accept button per entry with tooltip "Accept relation from space <name>", and moves the relation to Current on acceptance Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
provisional→tentativeonRelationInstanceand all related code for consistent product terminologyupdateRelation()torelationsStore.tsfor patching individual relation fieldsRelationshipSectioninto two sections:tentative !== false(local or accepted)tentative === false(imported, not yet accepted)"Accept relation from space <name>", and moves the relation to Current immediately on acceptanceTest plan
"Accept relation from space <name>"tentative: truein relations.json)🤖 Generated with Claude Code